Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translations #1762

Merged
merged 21 commits into from
Feb 14, 2019
Merged

Italian translations #1762

merged 21 commits into from
Feb 14, 2019

Conversation

xela92
Copy link
Contributor

@xela92 xela92 commented Aug 6, 2018

Hello,

This is my first pull request ever, so I want to be sure that's fine.

I'm starting a translating process of the NodeJS.org website to Italian language. I saw that only some menu voice was translated, so I wanted to contribute.

Is it ok? Till now I translated Governance page and copied the other templates from EN layout, and I'm gonna translate everything as soon as I can.

PS: thank you for your awesome project, I love NodeJS.

@ghost
Copy link

ghost commented Aug 7, 2018

Thanks for your contributions first!
Then I'll call the Italian group translators to have a review of what you did (including your correction, formation……ect).

/cc:@nodejs/nodejs-it

@fhemberger
Copy link
Contributor

Hi Alex,

blog entries are not translated to other languages, so you can safely delete everything in locale/it/blog. This will make the pull request easier to handle.

@fhemberger fhemberger added the i18n Issues/PRs related to the Website Internationalisation label Aug 25, 2018
Copy link
Member

@piccoloaiutante piccoloaiutante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to start this translation. I've added few suggestions to your pull request.

locale/it/about/community.md Show resolved Hide resolved
locale/it/about/community.md Outdated Show resolved Hide resolved
locale/it/about/community.md Outdated Show resolved Hide resolved
locale/it/about/community.md Outdated Show resolved Hide resolved
locale/it/about/community.md Outdated Show resolved Hide resolved
locale/it/about/index.md Outdated Show resolved Hide resolved
locale/it/about/index.md Outdated Show resolved Hide resolved
locale/it/about/index.md Outdated Show resolved Hide resolved
locale/it/about/index.md Outdated Show resolved Hide resolved
locale/it/about/index.md Outdated Show resolved Hide resolved
@piccoloaiutante
Copy link
Member

We might also get an help from @mcollina in reviewing this PR

layout: about.hbs
---

# Commissione Community
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not translate this sentence. I would treat the various WGs, team names as proper names. Community Committee should stay as "Community Committee", just like my name does not become Matthew.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally agree with that, in fact I think it's easier to read and understand if we translate roles; I don't think to roles as of names, I give more importance to what they represent to the reader.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably is, but it makes it unsearchable on the web.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? Too much distance between english page and italian one can cause problems?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the content and the interaction is in English. The name of the github repos are in English etc. Name of things should stay costant so the barrier between Italian and English is as thin as possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I disagree, but I do not want this initiative to stop. I’ll recuse myself from further reviews (because no, I cannot LGTM this).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not # Community Committee (Commissione Community) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool to me, maybe I'd prefer Commissione Community (Community Committee) but it's great in both ways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/intl we can probably write some guidelines on what shouldn't be translated when we come to a consent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't have guidelines about this, I'll follow @allevo suggestion and use # Community Committee (Commissione Community) , applying this paradigm to all names and committees. We can correct it later on if necessary.

locale/it/about/governance.md Outdated Show resolved Hide resolved
@zeke
Copy link
Contributor

zeke commented Sep 19, 2018

@xela92 are you aware of the https://github.com/nodejs/i18n effort? We are using a platform called Crowdin to facilitate community translations of the Node.js documentation. What you're doing here with this pull request is great, but your contributions will have more long-term value if you do your work here: https://crowdin.com/project/nodejs/it

@xela92
Copy link
Contributor Author

xela92 commented Sep 22, 2018

@zeke I didn't know about Crowdin, I checked but I couldn't find website md files to translate!

@fhemberger
Copy link
Contributor

@zeke The efforts on Crowdin are for the Node.js API docs while this PR is for the website's content. AFAIK there doesn't exist a setup for website translations there yet.

@xela92 I'd love to see a basic version of the site in Italian, you already did quite a lot yourself. Thank you for that! I think this would also be a good starting point for others to chime in and help.

You can also drop locale/it/knowledge completely (it's currently not shown on the website).

@fhemberger
Copy link
Contributor

@xela92 Could you please update your PR as requested? Would be cool if we could land this change soon.

@xela92
Copy link
Contributor Author

xela92 commented Dec 19, 2018

Sorry I had no time, will update it soon on these days :-)

@xela92
Copy link
Contributor Author

xela92 commented Dec 30, 2018

@fhemberger I'm updating my work, but I saw there were some changes in upstream, and for instance Governance page has been made much simpler. Now I'm trying to get aligned with the actual contents and also to merge the enhancements suggested and finish the remaining pages. Now on I'll hopefully have more time to work on it, but it still may be a long road to a complete, redacted and up-to-date translation; I don't know how it usually works with NodeJS PRs but in the meantime do you think that would be possible to start publishing this work instead of having no italian translations?

@fhemberger
Copy link
Contributor

@xela92 You don't have to do a full translation before it gets approved and released. The best way is to get a +1 from other native speakers for the current status of the translation, so it can be merged.

All further updated can be handled in a separate PR then. This makes reviewing also much easier.

/cc @nodejs/nodejs-it Please review, so we can get this merged.

@xela92
Copy link
Contributor Author

xela92 commented Jan 1, 2019

@fhemberger thank you so much for the help :-)

@ghost
Copy link

ghost commented Feb 2, 2019

Ref:#2024

@ghost ghost mentioned this pull request Feb 2, 2019
@xela92
Copy link
Contributor Author

xela92 commented Feb 2, 2019

@Maledong: still WIP, now I was waiting for the things already done to be merged, but seems it's not going to happen... @nodejs/nodejs-it please review so it can be merged, I don't want to complete a translation that maybe it's not going to be merged :-)

@lpinca
Copy link
Member

lpinca commented Feb 4, 2019

Can we reduce the diff to only include translated content? This PR is huge and hard to review.

@lpinca
Copy link
Member

lpinca commented Feb 4, 2019

If I'm not wrong only the following files have been translated:

  • about/community.md
  • about/governance.md
  • about/index.md
  • security.md
  • site.json

In that case it would ideal to only have those files in the diff.

@ghost
Copy link

ghost commented Feb 4, 2019

@xela92:Since you've fixed almost of them, would you mind merging them together for us to see the final result? I mean you can do a rebase to merge all of your changes into files one by one and submit forcely.

@xela92
Copy link
Contributor Author

xela92 commented Feb 9, 2019

@xela92:Since you've fixed almost of them, would you mind merging them together for us to see the final result? I mean you can do a rebase to merge all of your changes into files one by one and submit forcely.

I've never done a rebase before, I just tried doing a little change, running git rebase and then a forced push.
should be ok I guess :-)

@ghost
Copy link

ghost commented Feb 10, 2019

I've never done a rebase before, I just tried doing a little change, running git rebase and then a forced push. should be ok I guess :-)

Yes, you can just merge all of them into one for us to see clearly. But I didn't see anything forcely pushed ...

@fhemberger
Copy link
Contributor

@nodejs/website @nodejs/nodejs-it I'm thinking about merging this PR as it is for now and use subsequent PRs for fixes and updates. Otherwise it might be too big for further reviews. Thoughts?

Afterwards, we can look at #2024.

@lpinca
Copy link
Member

lpinca commented Feb 14, 2019

@fhemberger I would say go ahead and merge this.

@fhemberger fhemberger merged commit ef4326a into nodejs:master Feb 14, 2019
@fhemberger
Copy link
Contributor

Great, thanks everybody!

@xela92
Copy link
Contributor Author

xela92 commented Feb 14, 2019

Thank you so much everybody! I will continue the translation soon :-)

@ghost
Copy link

ghost commented Feb 17, 2019

Hi all:
Would you mind reviewing this submit:#2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants