Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide: "Anatomy of an HTTP Request" #218

Merged
merged 6 commits into from
Oct 20, 2015

Conversation

Qard
Copy link
Member

@Qard Qard commented Oct 7, 2015

Note: This is part of the migration of content files from https://github.com/nodejs/docs, see: nodejs/docs#44

@Qard
Copy link
Member Author

Qard commented Oct 9, 2015

@nodejs/documentation @nodejs/website Can I get a LGTM, just for good measure? :)

@fhemberger fhemberger added the content Issues/pr concerning content label Oct 9, 2015
@drewfish
Copy link

drewfish commented Oct 9, 2015

+1

@bengl
Copy link
Member

bengl commented Oct 9, 2015

The only thing I would add here is that the links to API docs are all linking to iojs.org, which was because at the time, nodejs.org did not have modern API docs. This should probably be changed, and now's a good time.

@Qard
Copy link
Member Author

Qard commented Oct 9, 2015

Ah, yep. I'll fix that. This was just a quick port of the commits. I didn't really look too closely at the content, since it had already gone through review on https://github.com/nodejs/docs.

@phillipj
Copy link
Member

phillipj commented Oct 9, 2015

Nice! Any plans for listing these guides? A completely new section or under docs maybe?

@silverwind
Copy link
Contributor

@phillipj yes, I think a 'Guides' section would be great for these kind of things. I had basically the same idea over at nodejs/docs#42.

@Qard
Copy link
Member Author

Qard commented Oct 14, 2015

The original plan for the docs wg, discussed back at nodeconf, was to sort docs into topics, guides and reference. We kind of dropped the ball on coordinating with website to figure out how this stuff would all appear though, which is what I'm working on fixing now. 😸

@phillipj
Copy link
Member

Looking forward to having these resources on the website 👍

@Qard so lets merge this content now, and figure out the best way to group/present them later in a separate issue?

@Qard
Copy link
Member Author

Qard commented Oct 15, 2015

Ok, it should be ready now. I just had to fix some links.

I'm good with merging and starting another PR to sort out linking to this content.

@fhemberger
Copy link
Contributor

Now we have PRs for adding pages as docs, meta docs, guides, topics and knowledge base. This is confusing for the users (at least it is for me now). I think having less categories (and/or a clearer structure) would be a better approach.

Otherwise LGTM.

@fhemberger fhemberger mentioned this pull request Oct 16, 2015
3 tasks
fhemberger added a commit that referenced this pull request Oct 20, 2015
Add guide: "Anatomy of an HTTP Request"
@fhemberger fhemberger merged commit a5235fc into nodejs:master Oct 20, 2015
@fhemberger
Copy link
Contributor

Merged, although it's not linked on the site yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants