Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MD033 rule #2382

Merged

Conversation

nschonni
Copy link
Member

No description provided.

@XhmikosR
Copy link
Contributor

@nschonni actually this PR changes more than h1s, don't forget to change the PR title and don't squash this.

We need this, along with my HTML validation fixes which flagged some of these.

@nschonni nschonni changed the title fix: Replace multiple H1s Enable MD033 rule Aug 15, 2019
.markdownlint.json Outdated Show resolved Hide resolved
@nschonni nschonni force-pushed the chore--Enable-MD033/no-inline-html branch 2 times, most recently from 67368d3 to 5289a08 Compare August 22, 2019 03:23
@XhmikosR
Copy link
Contributor

LGTM I also did the Markdown conversion in #2437, not by hand though.

Suppress currently flagged elements
Converte the resto of http-server-security-vulnerability-please-upgrade-to-0-6-17.md to pure MD at the same time
Was swallowed as HTML before
@nschonni nschonni force-pushed the chore--Enable-MD033/no-inline-html branch from 5289a08 to 725348a Compare August 23, 2019 04:33
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins merged commit 016c7ab into nodejs:master Aug 23, 2019
@nschonni nschonni deleted the chore--Enable-MD033/no-inline-html branch August 23, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants