-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable MD033 rule #2382
Merged
MylesBorins
merged 6 commits into
nodejs:master
from
nschonni:chore--Enable-MD033/no-inline-html
Aug 23, 2019
Merged
Enable MD033 rule #2382
MylesBorins
merged 6 commits into
nodejs:master
from
nschonni:chore--Enable-MD033/no-inline-html
Aug 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nschonni actually this PR changes more than We need this, along with my HTML validation fixes which flagged some of these. |
XhmikosR
reviewed
Aug 15, 2019
XhmikosR
reviewed
Aug 17, 2019
nschonni
force-pushed
the
chore--Enable-MD033/no-inline-html
branch
2 times, most recently
from
August 22, 2019 03:23
67368d3
to
5289a08
Compare
LGTM I also did the Markdown conversion in #2437, not by hand though. |
XhmikosR
reviewed
Aug 22, 2019
locale/en/blog/vulnerability/http-server-security-vulnerability-please-upgrade-to-0-6-17.md
Show resolved
Hide resolved
Suppress currently flagged elements
Converte the resto of http-server-security-vulnerability-please-upgrade-to-0-6-17.md to pure MD at the same time
Was swallowed as HTML before
nschonni
force-pushed
the
chore--Enable-MD033/no-inline-html
branch
from
August 23, 2019 04:33
5289a08
to
725348a
Compare
XhmikosR
approved these changes
Aug 23, 2019
MylesBorins
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.