Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation about debug with Eclipse IDE #2446

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Documentation about debug with Eclipse IDE #2446

merged 4 commits into from
Aug 27, 2019

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@SEWeiTung SEWeiTung self-requested a review August 24, 2019 06:00
SEWeiTung
SEWeiTung approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@SEWeiTung SEWeiTung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with it, with the missing Chinese language added.

@nodejs/website , what do you think of this？If you think it's OK, you can also add your own languages of translations.

3imed-jaberi
3imed-jaberi approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SEWeiTung
ar: fixture of Arabic
23d2f4b 
ar: fixture of Arabic
@Trott Trott merged commit c54ff3c into nodejs:master Aug 27, 2019
@MrStepz MrStepz mentioned this pull request May 24, 2022
Open
@NOUIY NOUIY mentioned this pull request Jun 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEWeiTung SEWeiTung SEWeiTung approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

@Aissaoui-Ahmed Aissaoui-Ahmed Aissaoui-Ahmed approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mickaelistria @aymen94 @Aissaoui-Ahmed @3imed-jaberi @SEWeiTung @Trott