Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete public/static/images/logos/nodejs-new-white.svg #5842

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

PriyaPrathapaneni
Copy link
Contributor

@PriyaPrathapaneni PriyaPrathapaneni commented Sep 22, 2023

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: PriyaPrathapaneni <123143104+PriyaPrathapaneni@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 6:24pm

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.59s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! 🚢 🎉

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Resolves #5836

@mikeesto mikeesto linked an issue Sep 23, 2023 that may be closed by this pull request
@mikeesto mikeesto mentioned this pull request Sep 23, 2023
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 23, 2023
Merged via the queue into nodejs:main with commit 886c308 Sep 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the nodejs-new-white.svg file
4 participants