fix: horizontal scrollbar appearing on small screen #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
canerakdas
reviewed
Apr 30, 2024
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Théo LUDWIG <contact@theoludwig.fr>
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Théo LUDWIG <contact@theoludwig.fr>
canerakdas
approved these changes
Apr 30, 2024
canerakdas
reviewed
Apr 30, 2024
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Théo LUDWIG <contact@theoludwig.fr>
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
The lint check gives an error; it's probably related to the order of the Tailwind classes. Can you re-run the format script 🙇 |
We will eventually get there. 😄 |
bmuenzenmeyer
approved these changes
May 3, 2024
ovflowd
approved these changes
May 3, 2024
There was a problem hiding this comment.
Awesome stuff, thank you so muhch @theoludwig for your continuous contributions. They are definitely appreciated and extremely welcome!
github-actions
bot
removed
the
github_actions:pull-request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On small screen (e.g: width 412px), on some security blog post page (e.g: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases), there is a horizontal scrollbar appearing because of the texts overflow in Table of Contents, and added padding in footer (we don't need this padding on small screens, as the "Trademark Policy", "Privacy Policy", etc. is centered).
We can clearly see the horizontal (overflow-x) scrollbar on this screen:
Validation
This PR fixes this issue by wrapping the texts:
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.