Optimize Performance #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflict is because of 5511f3c, rebased with master, don't know why git still sees conflicts here. cc @nodejs/website |
2 tasks
|
+1 although I wish there was an easy way to test to make sure analytics is still working the same. |
|
I thoroughly read that piece of analytics code a few times before I decided to merge it, looked okay for me. The generated code is also used by the H5BP, gulp and hapi projects. |
|
Sounds good then. +1 :) |
|
Cherry picked changes into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Google web-font loader and moved uncritical CSS out of the render path.
PageSpeed Insights before:
Mobile: 72/100, 98/100 (Usability)
Desktop: 88 / 100
PageSpeed Insights after:
Mobile: 90/100, 99/100 (Usability)
Desktop: 96/100