Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Reliability 2024-02-23 #791

Open
19 tasks
github-actions bot opened this issue Feb 23, 2024 · 0 comments
Open
19 tasks

CI Reliability 2024-02-23 #791

github-actions bot opened this issue Feb 23, 2024 · 0 comments

Comments

@github-actions
Copy link

Failures in node-test-pull-request/57217 to node-test-pull-request/57308 that failed 2 or more PRs
(Generated with ncu-ci walk pr --stats=true --markdown /home/runner/work/reliability/reliability/results.md)

UTC Time RUNNING SUCCESS UNSTABLE ABORTED FAILURE Green Rate
2024-02-23 00:08 8 0 4 1 87 0.00%

Jenkins Failure

Build Failure

Reason fatal: No rebase in progress?
Type BUILD_FAILURE
Failed PR 4 (https://github.com/nodejs/node/pull/51809/, https://github.com/nodejs/node/pull/51713/, https://github.com/nodejs/node/pull/51815/, https://github.com/nodejs/node/pull/51736/)
Appeared test-ibm-ubuntu2204_sharedlibs_container-x64-5, test-ibm-ubuntu2204_sharedlibs_container-x64-1, test-ibm-ubuntu2204_sharedlibs_container-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/57217/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57302/
Example
fatal: No rebase in progress?

Reason ERROR: Step �Publish JUnit test result report� failed: No test report files were found. Configuration error?
Type BUILD_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51439/)
Appeared test-azure_msft-win11_vs2022-arm64-6, test-azure_msft-win11_vs2022-arm64-1, test-azure_msft-win11_vs2022-arm64-5, test-azure_msft-win11_vs2022-arm64-4, test-azure_msft-win11_vs2022-arm64-2, test-azure_msft-win11_vs2022-arm64-3, test-rackspace-win2022_vs2022-x64-5, test-rackspace-win2022_vs2022-x64-1, test-azure_msft-win10_vs2019-x64-2, test-azure_msft-win11_vs2022-x64-4, test-azure_msft-win2016_vs2017-x64-1, test-rackspace-win2019_vs2019-x64-1, test-rackspace-win2022_vs2022-x64-3, test-azure_msft-win10_vs2019-x64-1, test-rackspace-win2019_vs2019-x64-2, test-azure_msft-win11_vs2022-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57238/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57249/
Example
ERROR: Step �Publish JUnit test result report� failed: No test report files were found. Configuration error?
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE

CCTest Failure

Reason Value of: (!expectation.read_expected)
Type CC_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51818/, https://github.com/nodejs/node/pull/51816/)
Appeared test-digitalocean-alpine315_container-x64-2, test-digitalocean-alpine318_container-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57234/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57252/
Example
Value of: (!expectation.read_expected)
  Actual: true
Expected: false

[  FAILED  ] InspectorSocketTest.HostIPv6NonRoutable (4999 ms)

JSTest Failure

Reason wasi/test-wasi
Type JS_TEST_FAILURE
Failed PR 23 (https://github.com/nodejs/node/pull/51097/, https://github.com/nodejs/node/pull/51439/, https://github.com/nodejs/node/pull/51804/, https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51713/, https://github.com/nodejs/node/pull/51645/, https://github.com/nodejs/node/pull/51818/, https://github.com/nodejs/node/pull/50737/, https://github.com/nodejs/node/pull/51801/, https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51816/, https://github.com/nodejs/node/pull/51810/, https://github.com/nodejs/node/pull/51821/, https://github.com/nodejs/node/pull/51447/, https://github.com/nodejs/node/pull/51623/, https://github.com/nodejs/node/pull/51557/, https://github.com/nodejs/node/pull/51808/, https://github.com/nodejs/node/pull/51815/, https://github.com/nodejs/node/pull/51736/, https://github.com/nodejs/node/pull/51820/, https://github.com/nodejs/node/pull/51826/, https://github.com/nodejs/node/pull/51800/, https://github.com/nodejs/node/pull/51809/)
Appeared test-azure_msft-win11_vs2022-arm64-4, test-azure_msft-win11_vs2022-arm64-3, test-azure_msft-win11_vs2022-arm64-6, test-azure_msft-win11_vs2022-arm64-5, test-azure_msft-win11_vs2022-arm64-2, test-azure_msft-win11_vs2022-arm64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57224/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57308/
Example
not ok 922 wasi/test-wasi
  ---
  duration_ms: 5724.98800
  severity: fail
  exitcode: 1
  stack: |-
    executing cant_dotdot
    (node:4596) ExperimentalWarning: WASI is an experimental feature and might change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)
    fd_prestat_get(3, 69752)
    fd_prestat_dir_name(3, 69776, 8)
    fd_prestat_get(4, 69752)
    fd_prestat_dir_name(4, 69776, 4)
    fd_prestat_get(5, 69752)
    fd_fdstat_get(3, 69704)
    path_open(3, 1, 1062, 14, 0, 264240830, 268435455, 0, 69700)
    
    executing cant_dotdot
    (node:9616) ExperimentalWarning: WASI is an experimental feature and might change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)
    fd_prestat_get(3, 69752)
    fd_prestat_dir_name(3, 69776, 8)
    fd_prestat_get(4, 69752)
    fd_prestat_dir_name(4, 69776, 4)
    fd_prestat_get(5, 69752)
    fd_fdstat_get(3, 69704)
    path_open(3, 1, 1062, 14, 0, 264240830, 268435455, 0, 69700)
    
    e...

Reason parallel/test-child-process-fork-net
Type JS_TEST_FAILURE
Failed PR 12 (https://github.com/nodejs/node/pull/51447/, https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51800/, https://github.com/nodejs/node/pull/51804/, https://github.com/nodejs/node/pull/51809/, https://github.com/nodejs/node/pull/51713/, https://github.com/nodejs/node/pull/51815/, https://github.com/nodejs/node/pull/51818/, https://github.com/nodejs/node/pull/51557/, https://github.com/nodejs/node/pull/51801/, https://github.com/nodejs/node/pull/51736/)
Appeared test-azure_msft-win2016_vs2017-x64-2, test-azure_msft-win11_vs2022-arm64-1, test-rackspace-win2019_vs2019-x64-4, test-rackspace-win2019_vs2019-x64-1, test-rackspace-win2022_vs2022-x64-2, test-azure_msft-win11_vs2022-arm64-4, test-rackspace-win2019_vs2019-x64-3, test-azure_msft-win11_vs2022-arm64-6, test-rackspace-win2022_vs2022-x64-4, test-azure_msft-win11_vs2022-arm64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57227/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57302/
Example
not ok 106 parallel/test-child-process-fork-net
  ---
  duration_ms: 529.00800
  severity: fail
  exitcode: 1
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 4.
        at mustCall (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:431:10)
        at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-child-process-fork-net.js:38:25)
        at Module._compile (node:internal/modules/cjs/loader:1368:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1426:10)
        at Module.load (node:internal/modules/cjs/loader:1205:32)
        at Module._load (node:internal/modules/cjs/loader:1021:12)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)
        at node:internal/main/run_main_module:28:49
    Mismatched <anonymous> function calls. Expected exactly 1, actual 4.
        at mustCall (C:\workspace\node-test-binary-windows-js-suites\node\test\common\inde...

Reason parallel/test-fs-watch-recursive-add-file-to-existing-subfolder
Type JS_TEST_FAILURE
Failed PR 9 (https://github.com/nodejs/node/pull/51800/, https://github.com/nodejs/node/pull/51439/, https://github.com/nodejs/node/pull/51801/, https://github.com/nodejs/node/pull/51816/, https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51758/, https://github.com/nodejs/node/pull/51390/, https://github.com/nodejs/node/pull/51820/, https://github.com/nodejs/node/pull/51826/)
Appeared test-macstadium-macos11.0-arm64-3, test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2, test-orka-macos11-x64-1, test-orka-macos11-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57235/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57296/
Example
not ok 3900 parallel/test-fs-watch-recursive-add-file-to-existing-subfolder
  ---
  duration_ms: 360065.22900
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-fs-watch-recursive-add-file
Type JS_TEST_FAILURE
Failed PR 6 (https://github.com/nodejs/node/pull/51808/, https://github.com/nodejs/node/pull/51818/, https://github.com/nodejs/node/pull/51439/, https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51390/)
Appeared test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2, test-macstadium-macos11.0-arm64-4, test-macstadium-macos11.0-arm64-3, test-orka-macos11-x64-2, test-orka-macos11-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57223/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57275/
Example
not ok 1011 parallel/test-fs-watch-recursive-add-file
  ---
  duration_ms: 120060.11200
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-fs-watch-recursive-add-file-to-new-folder
Type JS_TEST_FAILURE
Failed PR 5 (https://github.com/nodejs/node/pull/51801/, https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51758/, https://github.com/nodejs/node/pull/51390/, https://github.com/nodejs/node/pull/51826/)
Appeared test-macstadium-macos11.0-arm64-3, test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2, test-orka-macos11-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57243/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57304/
Example
not ok 3940 parallel/test-fs-watch-recursive-add-file-to-new-folder
  ---
  duration_ms: 360082.61300
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-blob-file-backed
Type JS_TEST_FAILURE
Failed PR 4 (https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51810/, https://github.com/nodejs/node/pull/51815/)
Appeared test-ibm-ubuntu2204_sharedlibs_container-x64-5, test-rackspace-win2019_vs2019-x64-1, test-ibm-rhel8-s390x-2, test-digitalocean-ubuntu2204_sharedlibs_container-x64-9
First CI https://ci.nodejs.org/job/node-test-pull-request/57228/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57286/
Example
not ok 352 parallel/test-blob-file-backed
  ---
  duration_ms: 202.59200
  severity: fail
  exitcode: 1
  stack: |-
    
    node:internal/blob:291
              const error = lazyDOMException('The blob could not be read', 'NotReadableError');
                            ^
    DOMException [NotReadableError]: The blob could not be read
        at BlobReader.<anonymous> (node:internal/blob:291:25)
    
    Node.js v22.0.0-pre
  ...


Reason parallel/test-fs-read-stream-concurrent-reads
Type JS_TEST_FAILURE
Failed PR 3 (https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51810/, https://github.com/nodejs/node/pull/51623/)
Appeared test-digitalocean-fedora38-x64-2, test-digitalocean-fedora38-x64-1, test-osuosl-debian11_container-armv7l-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57233/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57292/
Example
not ok 1433 parallel/test-fs-read-stream-concurrent-reads
  ---
  duration_ms: 120105.09600
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-http2-large-write-multiple-requests
Type JS_TEST_FAILURE
Failed PR 3 (https://github.com/nodejs/node/pull/51645/, https://github.com/nodejs/node/pull/51820/, https://github.com/nodejs/node/pull/51826/)
Appeared test-ibm-ubuntu2204_sharedlibs_container-x64-1, test-ibm-ubuntu2204_sharedlibs_container-x64-5, test-ibm-ubuntu2204_sharedlibs_container-x64-3
First CI https://ci.nodejs.org/job/node-test-pull-request/57259/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57296/
Example
not ok 3080 parallel/test-http2-large-write-multiple-requests
  ---
  duration_ms: 120095.85800
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-fs-watch-recursive-assert-leaks
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51390/)
Appeared test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57265/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57275/
Example
not ok 1016 parallel/test-fs-watch-recursive-assert-leaks
  ---
  duration_ms: 120078.37800
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-fs-watch-recursive-sync-write
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51390/)
Appeared test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57265/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57275/
Example
not ok 1019 parallel/test-fs-watch-recursive-sync-write
  ---
  duration_ms: 30334.18400
  severity: fail
  exitcode: 1
  stack: |-
    /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/parallel/test-fs-watch-recursive-sync-write.js:25
      throw new Error('timed out');
      ^
    
    Error: timed out
        at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/parallel/test-fs-watch-recursive-sync-write.js:25:9)
        at listOnTimeout (node:internal/timers:573:17)
        at process.processTimers (node:internal/timers:514:7)
    
    Node.js v21.6.3-pre
  ...


Reason parallel/test-fs-watch-recursive-update-file
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51768/, https://github.com/nodejs/node/pull/51390/)
Appeared test-digitalocean-freebsd12-x64-1, test-digitalocean-freebsd12-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/57265/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57275/
Example
not ok 1179 parallel/test-fs-watch-recursive-update-file
  ---
  duration_ms: 120079.51900
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-http-chunk-problem
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51809/, https://github.com/nodejs/node/pull/51783/)
Appeared test-digitalocean-ubuntu2204_sharedlibs_container-x64-9, test-ibm-ubuntu2204_sharedlibs_container-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/57251/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57274/
Example
not ok 1404 parallel/test-http-chunk-problem
  ---
  duration_ms: 120073.21600
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...


Reason parallel/test-http2-misbehaving-multiplex
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51623/)
Appeared test-orka-macos11-x64-2, test-macstadium-macos11.0-arm64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/57274/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57292/
Example
not ok 1552 parallel/test-http2-misbehaving-multiplex
  ---
  duration_ms: 517.11700
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:126
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected "actual" to be strictly unequal to: 5
        at Http2Server.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/parallel/test-http2-misbehaving-multiplex.js:45:10)
        at Http2Server.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/common/index.js:473:15)
        at Http2Server.emit (node:events:519:28)
        at ServerHttp2Session.sessionOnStream (node:internal/http2/core:3034:19)
        at ServerHttp2Session.emit (node:events:519:28)
        at emit (node:internal/http2/core:337:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:85:22) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 5,
      expected: 5,
      operator: 'notStrictEqual'
   ...

Reason parallel/test-performance-function
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51826/, https://github.com/nodejs/node/pull/51796/)
Appeared test-ibm-rhel8-x64-2, test-ibm-rhel8-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57296/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57301/
Example
not ok 2313 parallel/test-performance-function
  ---
  duration_ms: 191.69900
  severity: fail
  exitcode: 1
  stack: |-
    node:internal/histogram:291
        validateInteger(val, 'val', 1);
        ^
    
    RangeError [ERR_OUT_OF_RANGE]: The value of "val" is out of range. It must be >= 1 && <= 9007199254740991. Received 0
        at RecordableHistogram.record (node:internal/histogram:291:5)
        at processComplete (node:internal/perf/timerify:40:15)
        at timerified m (node:internal/perf/timerify:87:5)
        at /home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-performance-function.js:103:5 {
      code: 'ERR_OUT_OF_RANGE'
    }
    
    Node.js v22.0.0-pre
  ...


Reason parallel/test-runner-output
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51808/, https://github.com/nodejs/node/pull/51439/)
Appeared test-azure_msft-win10_vs2019-x64-1, test-equinix_mnx-smartos20-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/57223/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57236/
Example
not ok 659 parallel/test-runner-output
  ---
  duration_ms: 3736.01300
  severity: fail
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: test runner output
        # Subtest: test-runner/output/abort.js
        ok 1 - test-runner/output/abort.js
          ---
          duration_ms: 1694.2062
          ...


Reason wpt/test-wasm-webapi
Type JS_TEST_FAILURE
Failed PR 2 (https://github.com/nodejs/node/pull/51736/, https://github.com/nodejs/node/pull/51800/)
Appeared test-rackspace-win2022_vs2022-x64-6, test-rackspace-fedora32-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57302/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57306/
Example
not ok 972 wpt/test-wasm-webapi
  ---
  duration_ms: 555.00800
  severity: crashed
  exitcode: 3221225477
  stack: |-
    [SKIPPED] abort.any.js: WPTRunner does not support fetch()
    [SKIPPED] contenttype.any.js: WPTRunner does not support fetch()
    [SKIPPED] historical.any.js: indexedDB is not defined
    [SKIPPED] idlharness.any.js: not configured
    [SKIPPED] instantiateStreaming-bad-imports.any.js: Flaky on ARM with V8 >= 11.2
    [SKIPPED] origin.sub.any.js: CORS not implemented
    [SKIPPED] status.any.js: WPTRunner does not support fetch()
    [PASS] compileStreaming
    [PASS] instantiateStreaming
    [PASS] compileStreaming: no body
    [PASS] compileStreaming: no body in a promise
    [PASS] compileStreaming: empty body
    [PASS] compileStreaming: undefined
    [PASS] compileStreaming: undefined in a promise
    [PASS] compileStreaming: null
    [PASS] compileStreaming: null in a promise
    [PASS] compileStreaming: true
    [PASS] compileStreaming: true in a promise
    [PASS] compileStreamin...

Progress

  • fatal: No rebase in progress? (4)
  • ERROR: Step �Publish JUnit test result report� failed: No test report files were found. Configuration error? (2)
  • Value of: (!expectation.read_expected) (2)
  • wasi/test-wasi (23)
  • parallel/test-child-process-fork-net (12)
  • parallel/test-fs-watch-recursive-add-file-to-existing-subfolder (9)
  • parallel/test-fs-watch-recursive-add-file (6)
  • parallel/test-fs-watch-recursive-add-file-to-new-folder (5)
  • parallel/test-blob-file-backed (4)
  • parallel/test-fs-read-stream-concurrent-reads (3)
  • parallel/test-http2-large-write-multiple-requests (3)
  • parallel/test-fs-watch-recursive-assert-leaks (2)
  • parallel/test-fs-watch-recursive-sync-write (2)
  • parallel/test-fs-watch-recursive-update-file (2)
  • parallel/test-http-chunk-problem (2)
  • parallel/test-http2-misbehaving-multiplex (2)
  • parallel/test-performance-function (2)
  • parallel/test-runner-output (2)
  • wpt/test-wasm-webapi (2)
joyeecheung added a commit to nodejs/node that referenced this issue Feb 26, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this issue Feb 26, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this issue Feb 26, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this issue Feb 27, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit to nodejs/node that referenced this issue Mar 25, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit to nodejs/node that referenced this issue Mar 25, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: #51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rdw-msft pushed a commit to rdw-msft/node that referenced this issue Mar 26, 2024
If the server is not referenced, it might go away too soon
and the client may not get enough ends for it to close
itself, resulting a timeout.
This patch updates the test to simply close the server when
enough requests have been processed, and keep the server
referenced while the test is ongoing.

Drive-by: add more logs to facilitate debugging.
PR-URL: nodejs#51863
Refs: nodejs/reliability#791
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants