Make test pass in v19.x

[mcollina]

Signed-off-by: Matteo Collina hello@matteocollina.com

[mcollina]

@KhafraDev could you take a look? WPT has more failures.

> undici@5.16.0 test:wpt
> node scripts/verifyVersion 18 || (node test/wpt/start-fetch.mjs && node test/wpt/start-FileAPI.mjs && node test/wpt/start-mimesniff.mjs && node test/wpt/start-xhr.mjs && node test/wpt/start-websockets.mjs)

[fetch]: Completed: 1320, failed: 134, success: 1186, expected failures: 134, unexpected failures: 0, skipped: 0
(node:51672) ExperimentalWarning: buffer.File is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:51672) ExperimentalWarning: buffer.File is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:51672) ExperimentalWarning: buffer.File is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:51672) ExperimentalWarning: buffer.File is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
{
  status: 1,
  name: 'Blob interface: existence and properties of interface object',
  message: `assert_false: self's property "Blob" should not have a getter expected false got true`,
  stack: 'Error\n' +
    '    at get_stack (evalmachine.<anonymous>:4513:16)\n' +
    '    at new AssertionError (evalmachine.<anonymous>:4506:17)\n' +
    '    at assert (evalmachine.<anonymous>:4490:11)\n' +
    '    at assert_false (evalmachine.<anonymous>:1476:4)\n' +
    '    at assert_wrapper (evalmachine.<anonymous>:1436:19)\n' +
    '    at IdlInterface.<anonymous> (evalmachine.<anonymous>:1467:9)\n' +
    '    at Test.step (evalmachine.<anonymous>:2590:17)\n' +
    '    at test (evalmachine.<anonymous>:628:25)\n' +
    '    at self.subsetTestByKey (evalmachine.<anonymous>:44:14)\n' +
    '    at IdlInterface.test_self (evalmachine.<anonymous>:1453:5)'
}
[FileAPI]: Completed: 234, failed: 11, success: 223, expected failures: 10, unexpected failures: 1, skipped: 0

[KhafraDev]

The test is failing because of nodejs/node#45659, will have a fix soon

[KhafraDev]

I think the v19 CI should be enabled as well? https://github.com/nodejs/undici/blob/main/.github/workflows/nodejs.yml#L25

[mcollina]

@dominykas could you take a look? I don't know how to support it.

[KhafraDev]

it should be as easy as removing the line I linked to above

[codecov-commenter]

Codecov Report

Base: 90.32% // Head: 90.33% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1a0cf69) compared to base (25a8aac).
Patch has no changes to coverable lines.

❗ Current head 1a0cf69 differs from pull request most recent head 990302f. Consider uploading reports for the commit 990302f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   90.32%   90.33%   +0.01%     
==========================================
  Files          70       70              
  Lines        6045     6045              
==========================================
+ Hits         5460     5461       +1     
+ Misses        585      584       -1     

Impacted Files	Coverage Δ
lib/fetch/file.js	90.80% <0.00%> (+1.14%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mcollina]

I think this is almost good to go. Could I get a couple of LGTMs?

[ronag]

Checks are still failing?

[mcollina]

Only on Windows. @KhafraDev PTAL:

> node scripts/verifyVersion 18 || (node test/wpt/start-fetch.mjs && node test/wpt/start-FileAPI.mjs && node test/wpt/start-mimesniff.mjs && node test/wpt/start-xhr.mjs && node test/wpt/start-websockets.mjs)

Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\content-encoding\bad-gzip-body.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\data-urls\base64.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\data-urls\processing.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\accept-header.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\header-value-combining.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\header-value-null-byte.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\http-response-code.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\integrity.sub.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\request-headers-nonascii.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\request-upload.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\scheme-blob.sub.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\stream-response.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\stream-safe-creation.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\basic\text-utf8.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\credentials\authentication-redirection.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\redirect\redirect-location.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\redirect\redirect-method.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\redirect\redirect-schemes.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\redirect\redirect-to-dataurl.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\json.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-cancel-stream.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-clone.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-static-error.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-stream-disturbed-1.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-stream-disturbed-2.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-stream-disturbed-3.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-stream-disturbed-4.any.js
Test timed out: D:\a\undici\undici\test\wpt\tests\fetch\api\response\response-stream-disturbed-5.any.js
{
  status: 1,
  name: 'response.arrayBuffer() rejects if already aborted',
  message: 'assert_unreached: Should have rejected: undefined Reached unreachable code',
  stack: 'Error\n' +
    '    at get_stack (evalmachine.<anonymous>:4513:16)\n' +
    '    at new AssertionError (evalmachine.<anonymous>:4506:17)\n' +
    '    at assert (evalmachine.<anonymous>:4490:11)\n' +
    '    at assert_unreached (evalmachine.<anonymous>:2348:5)\n' +
    '    at Test.<anonymous> (evalmachine.<anonymous>:2683:5)\n' +
    '    at Test.step (evalmachine.<anonymous>:2590:17)\n' +
    '    at evalmachine.<anonymous>:2637:27\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' +
    '    at async Test.<anonymous> (evalmachine.<anonymous>:237:5)'
}
[fetch]: Completed: 1320, failed: 138, success: 1182, expected failures: 137, unexpected failures: 1, skipped: 0
Error: Process completed with exit code 1.

[mcollina]

{
  status: 1,
  name: 'Underlying connection is closed when aborting after receiving response',
  message: 'promise_test: Unhandled rejection with value: object "TypeError: fetch failed"',
  stack: 'Error\n' +
    '    at get_stack (evalmachine.<anonymous>:4513:16)\n' +
    '    at new AssertionError (evalmachine.<anonymous>:4506:17)\n' +
    '    at assert (evalmachine.<anonymous>:4490:11)\n' +
    '    at Test.<anonymous> (evalmachine.<anonymous>:759:9)\n' +
    '    at Test.step (evalmachine.<anonymous>:2590:17)\n' +
    '    at evalmachine.<anonymous>:2637:27'
}

[KhafraDev]

I can't repro locally (I've ran the wpt runner hundreds of times, not a single test failure/hang on v19.5.0), but these tests do occasionally have issues:

• The first failure has been an issue for some time, and a really hard problem to diagnose. For some reason, the abort event is being dispatched after the response has succeeded, and the body consumed. What should be happening is that the controller is aborted after the request succeeds, and then reads the body. This is what the test is doing:

const ac = new AbortController()

const response = await fetch('...', { controller: ac.signal })

ac.abort() // "abort" event is dispatched, and once the event is handled, the response should be in an "aborted" state. This should theoretically happen before calling the body mixin below.

await response.arrayBuffer() // check if response's state is "aborted", and if so, reject.

• The second is strange because it's not an issue with the test; somewhere in fetch an error is being thrown (causing the "fetch failed" message).

---

Sooo.... the first test is flaky and the second one is an issue in fetch (maybe the server was closed?). Although I reran the tests one more time and it passed.

[mcollina]

I reliably reproduce the failures 100% of times in my Windows v10 virtualized.

[KhafraDev]

Ill setup a vm then, in the meantime the tests can be marked as flaky in the status file(s) https://github.com/nodejs/undici/tree/main/test/wpt/status

[mcollina]

@KhafraDev works!