fix: pass ProxyAgent proxy status code error

[NBNGaming]

Fixes: #2161

[ronag]

This doesn't follow spec.

[KhafraDev]

also needs a test

[codecov-commenter]

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (c415fbb) 85.98% compared to head (00f40cd) 85.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
- Coverage   85.98%   85.96%   -0.02%     
==========================================
  Files          76       76              
  Lines        6612     6614       +2     
==========================================
+ Hits         5685     5686       +1     
- Misses        927      928       +1     

Impacted Files	Coverage Δ
lib/fetch/index.js	85.19% <50.00%> (-0.13%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[metcoder95]

Any update @NBNGaming ?

[NBNGaming]

Any update @NBNGaming ?

I'm sorry, I don't have free time right now to make the required changes to the commit.

[ronag]

Why are we not just passing the error as the cause?

[NBNGaming]

I didn't quite understand your remark, but RequestAbortedError constructor doesn't have a cause argument and makeAppropriateNetworkError overrides error.

[ronag]

diff --git a/lib/fetch/index.js b/lib/fetch/index.js
index d615f07e..8faae32a 100644
--- a/lib/fetch/index.js
+++ b/lib/fetch/index.js
@@ -1760,7 +1760,7 @@ async function httpNetworkFetch (
       fetchParams.controller.connection.destroy()
 
       // 2. Return the appropriate network error for fetchParams.
-      return makeAppropriateNetworkError(fetchParams)
+      return makeAppropriateNetworkError(fetchParams, err)
     }
 
     return makeNetworkError(err)
diff --git a/lib/fetch/response.js b/lib/fetch/response.js
index 1029dbef..965127be 100644
--- a/lib/fetch/response.js
+++ b/lib/fetch/response.js
@@ -426,15 +426,15 @@ function filterResponse (response, type) {
 }
 
 // https://fetch.spec.whatwg.org/#appropriate-network-error
-function makeAppropriateNetworkError (fetchParams) {
+function makeAppropriateNetworkError (fetchParams, err = null) {
   // 1. Assert: fetchParams is canceled.
   assert(isCancelled(fetchParams))
 
   // 2. Return an aborted network error if fetchParams is aborted;
   // otherwise return a network error.
   return isAborted(fetchParams)
-    ? makeNetworkError(new DOMException('The operation was aborted.', 'AbortError'))
-    : makeNetworkError('Request was cancelled.')
+    ? makeNetworkError(Object.assign(new DOMException('The operation was aborted.', 'AbortError'), { cause: err })
+    : makeNetworkError(Object.assign(new DOMException('Request was cancelled.'), { cause: err })
 }
 
 // https://whatpr.org/fetch/1392.html#initialize-a-response

[NBNGaming]

I implemented the required changes and added a test.

[KhafraDev]

Subtest: pass ProxyAgent proxy status code error when using fetch - \#2161
        not ok 1 - should have the named property
          ---
          found:
            !error
            name: TypeError
            message: fetch is not a function
            stack: >-
              TypeError: fetch is not a function
                  at Test.<anonymous> (/home/runner/work/undici/undici/test/proxy-agent.js:459:11)
                  at processTicksAndRejections (internal/process/task_queues.js:95:5)
          pattern: cause
          at:
            line: 461
            column: 7
            file: test/proxy-agent.js
            type: Test
          stack: |
            Test.<anonymous> (test/proxy-agent.js:461:7)
          source: |2
              } catch (e) {
                t.hasProp(e, 'cause')
            ------^
              }
          ...
        
        1..1
        # failed 1 test

this test fails on v14