Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added XAPPLEPUSHSERVICE support (per #711) #712

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

titanism
Copy link
Contributor

This adds command support for XAPPLEPUSHSERVICE with a commented out IMAP command handler showing an example implementation.

@titanism
Copy link
Contributor Author

Got it working!!!! 🎉

This PR is ready for merge, please review and merge, thank you! ✅

If you'd like to see the working implementation, see these files:

Feel free to try it out on https://forwardemail.net with your iOS device (setup an IMAP account)

PUSH now supported on iOS!!!! ⚡ (our alternative since IDLE not supported on iOS Mail)

@titanism
Copy link
Contributor Author

OK it should be good to go now, I had one missing line of code (forgot to invoke this.send) with APS version and sub topic.

titanism@6e006db

PR ready.

@andris9 andris9 merged commit 4e96db2 into nodemailer:master Jul 29, 2024
4 checks passed
@andris9
Copy link
Member

andris9 commented Jul 29, 2024

Thanks for figuring this stuff out. I still need to edit it a bit; the commented-out code is not ideal; I will probably add a configuration option or smth.

@titanism titanism deleted the feature/xapplepushservice branch July 29, 2024 07:20
@titanism
Copy link
Contributor Author

Sounds good @andris9! Thank you 🙏

@andris9
Copy link
Member

andris9 commented Jul 29, 2024

Added the following changes (4ef3eaa):

  • fixed CAPABILITY listing for XAPPLEPUSHSERVICE (only visible for authenticated sessions)
  • made XAPPLEPUSHSERVICE configurable. Requires aps.enabled option to be true, otherwise will reject the command
  • updated schema handling (previously invalid input like tag XAPPLEPUSHSERVICE with no arguments caused an uncaught exception)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants