-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added XAPPLEPUSHSERVICE support (per #711) #712
feat: added XAPPLEPUSHSERVICE support (per #711) #712
Conversation
Got it working!!!! 🎉 This PR is ready for merge, please review and merge, thank you! ✅ If you'd like to see the working implementation, see these files:
Feel free to try it out on https://forwardemail.net with your iOS device (setup an IMAP account) PUSH now supported on iOS!!!! ⚡ (our alternative since IDLE not supported on iOS Mail) |
…PLEPUSHSERVICE` command We were missing sending a response with the version and sub topic as seen in these references: <https://opensource.apple.com/source/dovecot/dovecot-293/dovecot/src/imap/cmd-x-apple-push-service.c.auto.html> <https://github.com/st3fan/dovecot-xaps-plugin/blob/3d1c71e0c78cc35ca6ead21f49a8e0e35e948a7c/xaps-imap-plugin.c#L158-L166>
OK it should be good to go now, I had one missing line of code (forgot to invoke PR ready. |
Thanks for figuring this stuff out. I still need to edit it a bit; the commented-out code is not ideal; I will probably add a configuration option or smth. |
Sounds good @andris9! Thank you 🙏 |
Added the following changes (4ef3eaa):
|
This adds command support for
XAPPLEPUSHSERVICE
with a commented out IMAP command handler showing an example implementation.