Skip to content

Bulgarian Translation #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 133 commits into from
Oct 13, 2016
Merged

Bulgarian Translation #530

merged 133 commits into from
Oct 13, 2016

Conversation

kalinchernev
Copy link
Contributor

Initially translated by me and later validated and kindly corrected by @ivaylospasov.
History of commits contain further details if necessary.
Feedback is welcome! :)

kalinchernev and others added 30 commits September 6, 2016 21:33
Copy link
Member

@riyadhalnur riyadhalnur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tag someone who could go over the translations and sign off on it?

@martinheidegger
Copy link
Contributor

The team effort is awesome 👍 👍 👍
@riyadhalnur Seems like they already did peer review (looking at the commits)?!

@jpwesselink
Copy link
Member

@lulusam
On Mon, Sep 19, 2016 at 01:02 Martin Heidegger notifications@github.com
wrote:

The team effort is awesome 👍 👍 👍
@riyadhalnur https://github.com/riyadhalnur Seems like they already did
peer review (looking at the commits)?!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#530 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABuvz3ety9YgZjFI-6NdwhLixAlUvjUsks5qrcMcgaJpZM4J_73Q
.

@kalinchernev
Copy link
Contributor Author

Hi all, I asked @ivaylospasov for a review before opening the pull request as he's working at a national media in Bulgaria and have perfect control of the written Bulgarian.
Further feedback is welcome! :)

@martinheidegger
Copy link
Contributor

@riyadhalnur Do you think the current review status is okay? @lulusam do you have time for a review?

@jpwesselink
Copy link
Member

Yes sorry, @lulusam, me mentioning you from mobile device lacked context, my apologies. Could you please take a peek at the Bulgarian translations? :D

@lulusam
Copy link

lulusam commented Sep 20, 2016

Hello guys, amazing effort! @jpwesselink no problem, thank you for the mention never the less! @martinheidegger indeed I would love to go trough the translations!:)

"footer-contribute-answer": "Отговори на въпрос",
"footer-about-header": "Относно",
"footer-about-build": "Създай упражнение",
"footer-about-host": "Организирай работилница",
Copy link

@lulusam lulusam Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confuses workshopper with workshop.
screen shot 2016-09-20 at 08 16 21

Instead of host workshopper use host an event

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean: "Организирай събитие" instead of "Организирай работилница"?

"building-workshops-title-info": "<a href=\"https://www.npmjs.org/package/workshopper\">Упражнение</a>",
"building-workshops-info": "за да вземете напълно функционален NodeSchool framework за създаване упражнение с CLI.",
"building-workshops-title-info2": "<a href=\"https://www.npmjs.org/package/adventure\">Приключение</a>",
"building-workshops-info2": "за да вземете по-лека алтернатива на Упражнението.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest sticking to workshopper instead of exercise for the entirety of the text.

"index-workshop-links-host": "Организирайте събитие",
"index-workshop-links-events": "Вижте всички събития",
"index-workshop-links-writeups": "Обобщение от предишни събития",
"index-upcoming-header": "Предстоящи работилници",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

събития instead of работилници

"index-header-bottomB": "или се запишете за нашия безплатен",
"index-header-bottomC": "имейл бюлетин",
"index-workshop-header": "Работилници",
"index-workshop-info": "Работилниците, провеждани на живо, обикновено са безплатни. Упражненията в тях се използват като учебна програма, а ментори помагат на участниците в решаването на предизвикателствата.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oбучения instead of Работилници

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm - this should be a global change everywhere, no?

"index-host-want-to-host2": "Източници и съвети",
"index-host-want-to-host3": "с които да разберете как става това.",
"index-workshopper-header": "Упражнения",
"index-workshopper-info": "Упражнение е име, използвано при модулите с отворен код в NodeSchool. Всички те са подходящи за самообучение (не е задължително да присъствате на събитие, за да работите по някой от тях), а и повечето работят офлайн.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Работилници instaed of Упражнения

"mentoring-still-unsure-headline": "Все още не сте сигурни дали можете да се справите?",
"mentoring-still-unsure-part1": "Просто опитайте някой от <a href=\"/#workshopper-list\">основните упражнения</a>.",
"host-header": "Организиране на NodeSchool събития",
"host-info": "NodeSchool е усправляван от общността проект със 100% отворен код. Това означава, че всеки може да ползва материали от NodeSchool и/или да организира събитие.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

усправляван -> управляван

Copy link

@lulusam lulusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall awesome work! There is a number of small corrections which can be made that will improve the overall clarity of the message. e.g. consistently using workshoppers instead of excersises and events/training instead of workshop..

@martinheidegger
Copy link
Contributor

@lulusam Awesome!

@riyadhalnur
Copy link
Member

Thank you @lulusam for going over it 😄 I think once the changes are made, we'll be good to go

@lulusam
Copy link

lulusam commented Sep 20, 2016

My pleasure! Very excited to see the website in the mother language:D

@kalinchernev
Copy link
Contributor Author

kalinchernev commented Sep 20, 2016

@lulusam comments and suggestions applied - many thanks for your time to make the review!
I went through the build/built version of the site checking for overall flow and context, I hope I managed to polish it all off. I'd say it's ready to merge, but please feel free to double-check again after updates.
Many thanks again!

@kalinchernev
Copy link
Contributor Author

Hi @lulusam the current version of the translations should be ok.
Any further feedback is welcome :)

@riyadhalnur
Copy link
Member

Hi @lulusam, did you get a chance to look over the changes @kalinchernev made?

@lulusam
Copy link

lulusam commented Oct 13, 2016

@riyadhalnur @kalinchernev , hey guys, I am sorry I have missed the previous message! The changes look great! Greets, Lily

@riyadhalnur
Copy link
Member

@lulusam No worries. I'm taking liberty then of merging this in. Thank you for the hard work @kalinchernev, @ivaylospasov and @lulusam 😃

@riyadhalnur riyadhalnur merged commit 052c063 into nodeschool:source Oct 13, 2016
@kalinchernev
Copy link
Contributor Author

Thanks a lot everyone! :)

On 13 Oct 2016 18:05, "Riyadh Al Nur" notifications@github.com wrote:

@lulusam https://github.com/lulusam No worries. I'm taking liberty then
of merging this in. Thank you for the hard work @kalinchernev
https://github.com/kalinchernev, @ivaylospasov
https://github.com/ivaylospasov and @lulusam
https://github.com/lulusam 😃


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#530 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1ZlKRVKjAhHpbExSQlgJPEKbpKKyvkks5qzlaugaJpZM4J_73Q
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants