Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't login once you incorrectly enter your login credentials #302

Closed
borromeotlhs opened this issue Aug 1, 2014 · 7 comments
Closed

Can't login once you incorrectly enter your login credentials #302

borromeotlhs opened this issue Aug 1, 2014 · 7 comments
Labels

Comments

@borromeotlhs
Copy link

I failed logging in, and now, I cannot seem to get the username and password prompt to attempt logging in again.

@borromeotlhs
Copy link
Author

This is from the beta preview of flowhub ui from the chrome web store.

@forresto forresto added the bug label Aug 2, 2014
@meetamit
Copy link

meetamit commented Aug 2, 2014

I'm unable to login altogether (regardless of having entered correct credentials). There's an error in the console about a 404 error for https://flowhub-gate.herokuapp.com//authenticate/really-long-token. Note that there's double slashes in the url, before "authenticate". When I manually query this with corrected slashes, it responds successfully with a token.

@borromeotlhs
Copy link
Author

OK, cool, but that URL is the one the app spits out. It is a bug, and
though I could manually work around it, it begs the question as to why the
flowhub app is doing it in the first place.

Thanks,
TJ
On Aug 2, 2014 4:05 PM, "Amit Sch" notifications@github.com wrote:

I'm unable to login altogether (regardless of having entered correct
credentials). There's an error in the console about a 404 error for
https://flowhub-gate.herokuapp.com//authenticate/really-long-token. Note
that there's double slashes in the url, before "authenticate". When I
manually query this with corrected slashes, it responds successfully
with a token.


Reply to this email directly or view it on GitHub
#302 (comment).

@rschwabco
Copy link

+1

@rhalff
Copy link

rhalff commented Aug 3, 2014

I experience the same problem and miss playing with the UI so much I've decided to get to the bottom of this.

Problem:

The URL parameter is defined here with slash:
https://github.com/noflo/noflo-ui/blob/master/Gruntfile.coffee#L86

The noflo-account element expects the url without slash:
https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L332
https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L207

The manifest probably needs the url with slash:
https://github.com/noflo/noflo-ui/blob/master/manifest.dist.json#L17

Convention for the noflo-account element seems to be without slash, the permissions convention is with slash.

The manifest permissions seem to require slashes:
https://developer.chrome.com/extensions/declare_permissions

Some possible solutions:

  • Use something within the noflo-account element to normalize the url.

  • Change the convention for the noflo-account element to expect urls with slashes.

  • Add a slash within the manifest, like so: "$NOFLO_OAUTH_GATE/".

    However, since the Gruntfile also allows the environment to set this url using process.env.NOFLO_OAUTH_GATE, any environment setting this will also have to be updated.

@forresto
Copy link
Member

forresto commented Aug 4, 2014

Since we haven't pushed a new version recently, this is probably an API change that might be able to be fixed to allow // ... @bergie ?

But we should fix it on both ends.

@bergie
Copy link
Member

bergie commented Aug 4, 2014

Thanks for reporting this! We'll deploy a fix soon (@forresto wanted to make a release anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants