Repository navigation
Replies: 1 comment
|
Accepted! Feel free to push up a PR and we can get this going ASAP! If you do not have time, let me know and I will see if anyone on the nono team has bandwidth |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I'm packaging nono for the official Debian archive (ITP #1152621). Debian builds Rust programs against crates that are packaged individually in the archive, so every crate in the dependency tree has to be packaged and kept up to date there.
The AWS SDK crates are currently always built, but they're only used for AWS SigV4 signing (
aws_auth) in nono-proxy. Would you consider putting that support behind a Cargo feature that stays enabled by default? Official nono builds would not change, and distributions could build without it.aws-config,aws-sigv4andaws-credential-typesare unconditional dependencies of nono-proxy.crates/nono-proxy/src/aws/(about 860 lines). The SDK is only called when a route has anaws_authblock, and no built-in profile or policy uses one. So for most users this code is compiled in but never runs.The motivation is the packaging and maintenance cost, not licensing, privacy or AWS itself. On Linux (x86_64), on v0.81.0:
nono-clibuild;aws-*crates, none of which are in Debian yet. That is about 40% of the new crates nono needs packaged before it can enter the archive;aws-sdk-stshad 36 releases in the last 12 months,aws-smithy-runtime20,aws-sigv416 andaws-config15. Each one is an update to carry in Debian, for a feature most Debian users won't use.Proposal
Following the existing
system-keyringpattern:The
awsmodule and the signing calls would then be behind#[cfg(feature = "aws-sigv4")].This is the important part. A build without the feature must never send a request that should have been signed without the signature:
aws_auth, so the error is clear rather than an unknown-field error;aws_auth, the profile or proxy config should be rejected at load time, for example: "aws_authon route<name>requires nono built with theaws-sigv4feature";nono whyandnono profilechecks should report the same error;--no-default-features --features system-keyringand test that rejection, so the gated build doesn't break unnoticed.Alternatives
If this doesn't fit the project's direction, Debian could carry a downstream patch that removes
aws_authsupport and rejects such profiles. I'd much rather not diverge from upstream on part of the proxy, though, so an upstream feature seems better for everyone.I'm happy to send a PR for this if the approach looks reasonable, and to adjust it to however you'd prefer the gate to be structured.
All reactions