Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated dependency on archive.m_context #113

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Bernadette-Mohr
Copy link
Collaborator

No description provided.

@Bernadette-Mohr Bernadette-Mohr linked an issue Jun 19, 2024 that may be closed by this pull request
@JFRudzinski
Copy link
Collaborator

@ladinesa Can you take a look at this? The installation is suddenly failing in the pipeline. It was working fine when I made a PR last night. The changes in this PR have no connection with this, but just to be sure I made a simple copy of develop and just added a comment to the code, and get the same errors.

@ladinesa
Copy link
Collaborator

ladinesa commented Jun 20, 2024

I think it is because mpcdf is down. maybe we can rerun later.

@JFRudzinski
Copy link
Collaborator

I think it is because mpcdf is down. maybe we can rerun later.

oh ok, makes sense...I did not notice this, thanks

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9595380425

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 88.201%

Totals Coverage Status
Change from base Build 9593354407: 0.06%
Covered Lines: 6242
Relevant Lines: 7077

💛 - Coveralls

@JFRudzinski
Copy link
Collaborator

@Bernadette-Mohr It's fixed! You can go ahead and merge it now

@Bernadette-Mohr Bernadette-Mohr merged commit 66ecb53 into develop Jun 20, 2024
3 checks passed
@Bernadette-Mohr Bernadette-Mohr deleted the 112-update-gromacs-parser branch June 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update gromacs parser
4 participants