-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences #2 #21
Merged
Merged
Preferences #2 #21
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
accddb9
Fix quality settings to apply to recaps
unclenoriega fb71892
add DefaultPrefs.json
unclenoriega 0dbb407
add DefaultPrefs.json
unclenoriega fe62268
Merge branch 'master' into preferences
unclenoriega a0d678f
Merge remote-tracking branch 'upstream/master'
unclenoriega d4935c0
Fix quality settings to apply to recaps
unclenoriega a07d579
Revert "Revert "Merge pull request #19 from unclenoriega/preferences""
unclenoriega 26e2850
Merge branch 'preferences' of https://github.com/unclenoriega/Lazyman…
unclenoriega 33f53be
fix recap quality
unclenoriega 6aec0c6
remove quality choice for recaps
unclenoriega 648d9b8
Add preference for CDN
unclenoriega d14c86f
missing } in DefaultPrefs.json
unclenoriega b06773e
Change FPS check to be more robust
unclenoriega 3174cb6
All stream qualities are included, with the chosen quality listed fir…
unclenoriega 705d00b
Recap streams are appended in the order found, or inserted at the beg…
unclenoriega e6497f4
Recaps no longer error with 'auto' quality
unclenoriega e39f7b0
Fix recap titles
unclenoriega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
[ | ||
{ | ||
"id": "show_scores", | ||
"label": "Show scores for recaps", | ||
"type": "bool", | ||
"default": "true" | ||
}, | ||
{ | ||
"id": "quality", | ||
"type": "enum", | ||
"label": "Quality", | ||
"values": ["Auto", "720p60", "720p", "540p", "504p", "360p", "288p"], | ||
"default": "Auto" | ||
}, | ||
{ | ||
"id": "cdn", | ||
"type": "enum", | ||
"label": "CDN", | ||
"values": ["Akamai", "Level 3"], | ||
"default": "Akamai" | ||
} | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the point of the quality setting to avoid the menu with different qualities?
To do that, we should probably just return an array with a single array item here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't see a menu with different qualities. I think I used to have that at some point, but now I don't see any way to choose the quality. Am I missing something?