Skip to content

Get rid of non-constexpr std::swap #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Get rid of non-constexpr std::swap #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/nonstd/string_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,9 +685,9 @@ class basic_string_view

nssv_constexpr14 void swap( basic_string_view & other ) nssv_noexcept
{
using std::swap;
swap( data_, other.data_ );
swap( size_, other.size_ );
const basic_string_view tmp(other);
other = *this;
*this = tmp;
}

// 24.4.2.6 String operations:
Expand Down