Skip to content

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. changed deleteObject to deleteObjectTagging
    After some investigations regarding the BZ, found out that deleteObject doesn't return an AccessDenied error when trying to delete an object without access permissions as it was in the past, instead it returns an empty object - {} .
    deleteObjectTagging still returns AccessDenied when trying to delete an object without access permissions.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed BZ #1827317

Testing Instructions:

@guymguym
Copy link
Member

@romayalon Is it an SDK issue or a server issue?
If server then not sure that all S3 compatible will behave this way, or even support deleteObjectTagging() at all...

@nimrod-becker
Copy link
Contributor

@guymguym that's a good point, but we know to differ between compatible and S3.
@romayalon lets do different cases ? for S3 deleteObjectTagging and for compatible deleteObjkect() ?

@romayalon romayalon force-pushed the romy-fix-blockstores3 branch from 5d76c6d to b754844 Compare May 3, 2020 17:06
@romayalon romayalon merged commit 40e7dca into noobaa:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants