Refactor backingstore mode info mapping and add severity #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
reviewed
Jun 28, 2020
nb-ohad
force-pushed
the
ohad-fix-backingstore-event-types
branch
from
981aa0c to
0e06bc0
Compare
romayalon
approved these changes
Jun 28, 2020
nb-ohad
force-pushed
the
ohad-fix-backingstore-event-types
branch
from
0e06bc0 to
1cf6e31
Compare
Also removed BackingStorePhaseInfo from backingstore_types.go as it is an interal structure that is not part of the backingstore API and should be treated as such (the struct only serve as an implementation detail)
nb-ohad
force-pushed
the
ohad-fix-backingstore-event-types
branch
from
1cf6e31 to
a41e1a7
Compare
guymguym
reviewed
Jun 28, 2020
| "IO_ERRORS": {nbv1.BackingStorePhaseRejected, "BackingStorePhaseRejected", "Backing store mode: IO_ERRORS"}, | ||
| "STORAGE_NOT_EXIST": {nbv1.BackingStorePhaseRejected, "BackingStorePhaseRejected", "Backing store mode: STORAGE_NOT_EXIST"}, | ||
| "AUTH_FAILED": {nbv1.BackingStorePhaseRejected, "BackingStorePhaseRejected", "Backing store mode: AUTH_FAILED"}, | ||
| func modeInfoMap() map[string]ModeInfo { |
There was a problem hiding this comment.
@nb-ohad Why do you use an init() function to call another function just to return a map when you can create the map directly on the global var - am I missing something?
var bsModeInfoMap = map[string]ModeInfo{
"INITIALIZING": {nbv1.BackingStorePhaseReady, corev1.EventTypeNormal},
"DELETING": {nbv1.BackingStorePhaseReady, corev1.EventTypeNormal},
"SCALING": {nbv1.BackingStorePhaseReady, corev1.EventTypeNormal},
...
}
There was a problem hiding this comment.
@guymguym this was in the original code. I didn't change it. But you are perfectly right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackingStorePhaseInfofrombackingstore_types.goto the reconciler (the struct only serve as an implementation detail and should not be exposed as an API)BackingStorePhaseInfoBackingStorePhaseInfo, to represent an event severity attached to the modeBackingStorePhaseInfoto better fit its actual usage.Fixing BZ 1847815