Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount configuration URL is not properly generated in virtual directories #3292

Closed
AndreiMaz opened this issue Sep 14, 2018 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@AndreiMaz
Copy link
Member

As per our premium support ticket number 14378

It appears to be a path issue when running nopCommerce as a sub-application under a parent domain. Virtual path is generatead twice. For example. www.test.com/path/path/Admin/DiscountRulesCustomerRoles/Configure?discountId=18 instead of www.test.com/path/Admin/DiscountRulesCustomerRoles/Configure?discountId=18

I believe it's the "GetConfigurationUrl" method that has the issue in case of sub-applications.

var url = $"{_webHelper.GetStoreLocation()}{discountRequirementRule.GetConfigurationUrl(discount.Id, discountRequirementId)}";

@AndreiMaz AndreiMaz added the bug label Sep 14, 2018
@AndreiMaz AndreiMaz added this to the Version 4.20 milestone Sep 14, 2018
@RomanovM
Copy link
Contributor

See also: #2833

DmitriyKulagin added a commit that referenced this issue Sep 18, 2018
@DmitriyKulagin
Copy link
Contributor

Closed #3292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants