Skip to content

Conversation

RyanZim
Copy link
Contributor

@RyanZim RyanZim commented Apr 10, 2017

Since we're not supporting Node versions less than v4, there's no reason to check if fs.access() exists.

Also changed fs.exists to use access, since I believe I heard it's faster.

@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 92.0% when pulling f641bb8 on RyanZim:access into 9aea3f5 on normalize:master.

@dead-horse
Copy link
Member

we haven't declare node version in package.json, so it is support less than v4 now.

@RyanZim
Copy link
Contributor Author

RyanZim commented Apr 10, 2017

Gotcha, just assumed you only supported Node 4+ due to the .travis.yml

@RyanZim RyanZim closed this Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants