Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Formula Mk5 node #3874

Merged
merged 9 commits into from
Feb 5, 2021
Merged

New Formula Mk5 node #3874

merged 9 commits into from
Feb 5, 2021

Conversation

vicdoval
Copy link
Collaborator

@vicdoval vicdoval commented Feb 4, 2021

Fixes #3727 and gathers some of the ideas said in that issue.

More flexibility with a new formula socket that has some properties:
Depth: Exposed depth to the formula 1 would mean exposing scalars, 2 would be [scalar, ]
Transform: Pre transformation to Vector, to Numpy Array, to set or to String

image
image
Output socket options:
image

Numpy can be used for calculations
image

Example exposing attributes of a surface and using the node to perform a to_nurbs transform
image

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@Durman
Copy link
Collaborator

Durman commented Feb 4, 2021

If the node is in Alpha category should new version of it be created? I thought Alpha category means that API of a node can be changed without backward compatibility.

@vicdoval
Copy link
Collaborator Author

vicdoval commented Feb 4, 2021

the mk4 has been there since may of 2020...

@vicdoval vicdoval merged commit 84f938f into nortikin:master Feb 5, 2021
@nortikin
Copy link
Owner

nortikin commented Feb 6, 2021

Ahahaha!! that is what I wanted! Thanks!!!

@Durman
Copy link
Collaborator

Durman commented May 26, 2021

The name of the Formula socket is at least strange. I always thought that we have sockets type to determine which type of data the node is expecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formula+ overrides default node property "dimensions"
3 participants