-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(account): loading state #748
Conversation
Merge conflicts :( |
@fabric-8 could you have a sneak peak at the design side of things or guide me in the right direction? |
@DalderupMaurice I was able to remove the flicker after doctoring around a lot :D However, I noticed that while the transaction panel has an entire "custom loading component/state" it should actually just appear to be disabled while loading is in progress: https://www.figma.com/file/apqKpVZZDzppAb0lVH69iiZn/nOS-Client?node-id=2755%3A38184 ... or did I miss something? |
Codecov Report
@@ Coverage Diff @@
## develop #748 +/- ##
==========================================
- Coverage 54.54% 52.45% -2.1%
==========================================
Files 227 231 +4
Lines 1958 1977 +19
Branches 270 272 +2
==========================================
- Hits 1068 1037 -31
- Misses 733 776 +43
- Partials 157 164 +7 |
Description
This changes the way components and redux state are loaded in the account screen such that loading states can be rendered per panel within that screen. It still depends on some style updates from @fabric-8 before it will be ready.
The code changes here also will never transition from loading to loaded, simply because it's easier to observe the loading state during development. Before merging, that change must be reverted.
Motivation and Context
The current loading state is unappealing and doesn't match designs.
How Has This Been Tested?
Navigating to the account screen.
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #408