Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoUpdate): disable update check in dev mode #854

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jan 26, 2019

Description

disable update check in dev mode

Motivation and Context

client failed to build without the dev file or without the if statement

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 26, 2019
@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #854 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #854   +/-   ##
========================================
  Coverage    54.54%   54.54%           
========================================
  Files          227      227           
  Lines         1958     1958           
  Branches       270      270           
========================================
  Hits          1068     1068           
  Misses         733      733           
  Partials       157      157

@DalderupMaurice DalderupMaurice merged commit c647a17 into develop Jan 26, 2019
@DalderupMaurice DalderupMaurice deleted the chore/auto-updates-dev-fix branch January 26, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant