Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(networks): fix network issue #880

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Feb 15, 2019

Description

Fixes a network issue

Motivation and Context

It removed the custom networks

How Has This Been Tested?

manually

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #356

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #880 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #880   +/-   ##
========================================
  Coverage    52.45%   52.45%           
========================================
  Files          231      231           
  Lines         1977     1977           
  Branches       272      272           
========================================
  Hits          1037     1037           
  Misses         776      776           
  Partials       164      164

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Feb 15, 2019
@DalderupMaurice DalderupMaurice merged commit c78560f into develop Feb 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-network-issue branch February 15, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom networks in dropdown occasionally not showing
1 participant