Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(login/register): completely overhaul login/register flow #903

Merged
merged 15 commits into from
Mar 3, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 3, 2019

Description

Adjust register/login flow

  • Completely reworked register flow
  • Added login through "wallet profiles" dropdown
  • Added last used account support for the new wallet profiles
  • Added hide/unhide functionality for account data

Motivation and Context

Onboarding was too difficult

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #893

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #903 into develop will increase coverage by 0.04%.
The diff coverage is 39.47%.

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
+ Coverage    52.45%   52.49%   +0.04%     
===========================================
  Files          231      235       +4     
  Lines         1977     2002      +25     
  Branches       272      274       +2     
===========================================
+ Hits          1037     1051      +14     
- Misses         776      787      +11     
  Partials       164      164

@DalderupMaurice DalderupMaurice marked this pull request as ready for review March 3, 2019 13:58
@DalderupMaurice DalderupMaurice changed the title Feat/adjust login flow feat(login/register): completely overhaul login/register flow Mar 3, 2019
@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Mar 3, 2019
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Mar 3, 2019
@DalderupMaurice DalderupMaurice merged commit 83fc86a into develop Mar 3, 2019
@DalderupMaurice DalderupMaurice deleted the feat/adjust-login-flow branch March 3, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically store newly generated accounts
1 participant