Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(login): fix issue when creating new wallet through login screen #907

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 4, 2019

Description

Fixes an issue caused in the previous PR

Motivation and Context

It's broken

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #907 into develop will decrease coverage by 0.1%.
The diff coverage is 12.5%.

@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
- Coverage    52.49%   52.39%   -0.11%     
===========================================
  Files          235      235              
  Lines         2002     2006       +4     
  Branches       274      274              
===========================================
  Hits          1051     1051              
- Misses         787      791       +4     
  Partials       164      164

@DalderupMaurice DalderupMaurice merged commit eef185e into develop Mar 4, 2019
@DalderupMaurice DalderupMaurice deleted the chore/pr-followup-fix branch March 4, 2019 07:59
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant