Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(account): fixed wallet not rendering using testNet #927

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 13, 2019

Description

Fixed an issue where the wallet did not render when having the testnet selected

Motivation and Context

wallet loading broke

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #927 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #927      +/-   ##
===========================================
+ Coverage     52.3%   52.35%   +0.04%     
===========================================
  Files          236      236              
  Lines         2019     2021       +2     
  Branches       277      277              
===========================================
+ Hits          1056     1058       +2     
  Misses         796      796              
  Partials       167      167

@DalderupMaurice DalderupMaurice merged commit c76d284 into develop Mar 13, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-wallet-rendering branch March 13, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant