Make mypy pass and add it to CI #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some obsolete flake8 ignores (from an older version of flake8, IIRC).
Minor adjustments to pass mypy. Mostly applying some missing annotations. For one of these, the fix is actually to annotate a type in `nose2/events.py`.
This fixes a number of mypy errors. Additionally, replace a lambda to allow for better type inference (removes a misc mypy error).
Using ModuleType is a little heavy-handed. Avoiding it, a lighter touch, better preserves information about the optional modules.
Specifically, various tests which assign attributes to functions need attr-defined ignore rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, get type checking to pass and start enforcing it.