Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: enable CPU affinity for Node main thread to avoid context switch #11

Open
wants to merge 1,113 commits into
base: anode-v16.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1113 commits
Select commit Hold shift + click to select a range
4e87ef4
report: add queue info for udp
theanarkh Aug 24, 2022
5275c1e
meta: update AUTHORS
nodejs-github-bot Aug 28, 2022
b204087
meta: update AUTHORS
nodejs-github-bot Sep 4, 2022
e4cb157
tools: update eslint to 8.23.0
nodejs-github-bot Aug 27, 2022
ce60510
tools: update doc to unist-util-visit@4.1.1
nodejs-github-bot Aug 28, 2022
be1a22d
tools: don't use f-strings in test.py
santigimeno Aug 28, 2022
5869595
tools: update lint-md-dependencies to rollup@2.79.0
nodejs-github-bot Sep 4, 2022
2f864b1
lib: use safe `Promise` alternatives when available
aduh95 Aug 17, 2022
ffd44b0
debugger: decrease timeout used to wait for the port to be free
joyeecheung Aug 24, 2022
f06cd76
src: make minor improvements to SecureBuffer
tniessen Aug 22, 2022
2fe716b
tls: use OpenSSL constant for client random size
tniessen Aug 22, 2022
3b7beea
test: raise sleep times in child process tests
joyeecheung Aug 25, 2022
3115dda
test: fix multiple incorrect mustNotCall() uses
tniessen Aug 30, 2022
6cf65f2
test: split heap prof tests
joyeecheung Aug 25, 2022
2802d1f
test: make the vm timeout escape tests more lenient
joyeecheung Aug 29, 2022
c9b5239
test: deflake child process exec timeout tests
joyeecheung Aug 25, 2022
885468a
test: avoid race in file write stream handle tests
joyeecheung Aug 24, 2022
2cd3c02
crypto: improve RSA-PSS digest error messages
tniessen Aug 22, 2022
10939d7
src: fix multiple format string bugs
tniessen Aug 22, 2022
ec4c256
tty: fix TypeError when stream is closed
aduh95 Aug 24, 2022
515fcc2
src: remove KeyObjectData::symmetric_key_len_
tniessen Aug 24, 2022
9ceeb24
node-api: cleanup redundant static modifiers
legendecas Aug 25, 2022
9607c25
src: simplify ECDH::GetCurves()
tniessen Aug 26, 2022
eda025f
build: add --libdir flag to configure
sgallagher Aug 28, 2022
95869c2
src: simplify and optimize GetOpenSSLVersion()
tniessen Aug 28, 2022
43f2843
cluster: fix cluster rr distribute error
theanarkh Aug 28, 2022
4bf4903
src: trace fs async api
theanarkh Aug 28, 2022
638a6cf
src: fix ssize_t error from nghttp2.h
RaisinTen Aug 29, 2022
8e0a63c
src: make Endianness an enum class
tniessen Aug 30, 2022
ae6f292
src: fix uv_err_name memory leak
theanarkh Aug 30, 2022
9cc9dc5
src: remove base64_select_table and base64_table
tniessen Aug 31, 2022
9a8f6e8
node-api: avoid calling virtual methods in base's dtor
legendecas Aug 31, 2022
bb2a5b2
src: add error handling to `uv_uptime` call
juanarbol Aug 24, 2022
3d5b306
src: avoid casting std::trunc(... / ...) to size_t
tniessen Sep 1, 2022
216a4e8
src: fix incorrect comments in crypto
tniessen Sep 1, 2022
2b8c304
src: improve error handling in CloneSSLCerts
tniessen Sep 1, 2022
0333592
crypto: add digest name to INVALID_DIGEST errors
tniessen Sep 2, 2022
07bca09
net: add local family
theanarkh Jul 26, 2022
466862c
http: make idle http parser count configurable
theanarkh Jul 29, 2022
d1bdb35
lib: make `validateObject` less affected by prototype tampering
aduh95 Jul 11, 2022
8b349c8
bootstrap: stop delaying instantiation of maps in per-context scripts
RaisinTen May 5, 2022
e02a18c
buffer: fix `atob` input validation
austinkelleher Apr 12, 2022
8484554
lib: refactor `validateInt32` and `validateUint32`
mawaregetsuka May 22, 2022
4644f38
src: use a typed array internally for process._exiting
RaisinTen Jul 31, 2022
9e8a7f6
net,tls: pass a valid socket on `tlsClientError`
daeyeon Aug 1, 2022
fa3904e
util: add `maxArrayLength` option to Set and Map
cola119 Jul 14, 2022
67cfeef
src: nest namespace report in namespace node
legendecas Jul 31, 2022
a2d55ae
lib: reset `RegExp` statics before running user code
aduh95 Aug 5, 2022
8ee87f5
doc: add performance note to `--enable-source-maps` docs
saurabhdaware Aug 6, 2022
2980e5a
src: fix cppgc incompatibility in v8
codebytere Jun 21, 2022
df11d14
typings: add JSDoc for `internal/validators`
anonrig Aug 17, 2022
ee97c09
report: print javascript stack on fatal error
legendecas Aug 15, 2022
cb141ac
tls: remove SecureContext setFreeListLength
tniessen Aug 22, 2022
ca457e0
report: expose report public native apis
legendecas Aug 24, 2022
410a0f5
inspector: prevent integer overflow in open()
tniessen Aug 25, 2022
88f31e4
test: split report OOM tests
joyeecheung Aug 25, 2022
c0b5d70
doc,worker: document resourceLimits overrides
kvakil Aug 29, 2022
730d34d
os: add machine method
theanarkh Aug 29, 2022
ae47a85
lib: add diagnostics channel for process and worker
theanarkh Aug 30, 2022
84a5e76
crypto: use actual option name in error message
tniessen Aug 31, 2022
0df8f18
src: expose environment RequestInterrupt api
legendecas Aug 21, 2022
91e7bc9
report: fix missing section javascriptHeap on OOMError
legendecas Aug 25, 2022
68b1e37
report: get stack trace with cross origin contexts
legendecas Aug 26, 2022
be1c1db
crypto: handle invalid prepareAsymmetricKey JWK inputs
panva Sep 3, 2022
de19589
src: rename misleading arg in ClientHelloParser
tniessen Sep 4, 2022
74652b7
doc: move policy docs to the permissions scope
RafaelGSS Sep 5, 2022
8028eae
test: add more cases for parse-encoding
tony-go Sep 6, 2022
079f0ad
test: fix DebugSymbolsTest.ReqWrapList on PPC64LE
danbev Aug 22, 2022
8322491
doc: document attribute Script.cachedDataRejected
legendecas Sep 6, 2022
d67be13
deps: update to uvwasi 0.0.13
cjihrig Sep 5, 2022
aac9121
lib: fix reference leak
falsandtru Sep 7, 2022
0c5b425
v8: add setHeapSnapshotNearHeapLimit
theanarkh Sep 8, 2022
cc229a3
tools: fix shebang to use python3 by default
himself65 Sep 8, 2022
b1ac803
doc: emphasize that createCipher is never secure
tniessen Sep 8, 2022
a832f57
stream: add `ReadableByteStream.tee()`
daeyeon Sep 8, 2022
ced45c0
doc: remove ebpf from supported tooling list
RafaelGSS Sep 9, 2022
c5d28fd
test: use python3 instead of python
lpinca Sep 10, 2022
9a94062
doc: do not use weak MODP group in example
tniessen Sep 10, 2022
b11d8f7
crypto: restrict PBKDF2 args to signed int
tniessen Sep 10, 2022
c43a3aa
meta: update AUTHORS
nodejs-github-bot Sep 11, 2022
5514081
doc: fix link in `process.md`
aduh95 Sep 11, 2022
75e3133
doc: mention how to get commit release
RafaelGSS Sep 11, 2022
7983ec0
tools: increase timeout of running WPT
joyeecheung Sep 11, 2022
d75cc51
build: rewritten the Android build system
MeowShe Sep 12, 2022
dfa2159
doc: fix vm.Script createCachedData example
legendecas Sep 12, 2022
d64f5d6
doc: fix errors in http.md
lpinca Sep 12, 2022
207ff52
doc: fix heading levels for test runner hooks
meyfa Sep 12, 2022
394e691
doc: remove old OpenSSL ENGINE constants
tniessen Sep 12, 2022
62f94ec
doc: deprecate modp1, modp2, and modp5 groups
tniessen Sep 12, 2022
0ebc683
test: ignore stale process cleanup failures on Windows
joyeecheung Sep 13, 2022
70e05b4
inspector: expose inspector.close on workers
legendecas Sep 13, 2022
db85799
win: fix fs.realpath.native for long paths
StefanStojanovic Sep 13, 2022
56f8da5
src: dump isolate stats when process exits
qdaoming Sep 13, 2022
efb8b15
stream: refactor use es2020 statement
xtx1130 Sep 6, 2022
8850d74
benchmark: add stream destroy benchmark
xtx1130 Sep 7, 2022
4e67a27
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.0.1
nodejs-github-bot Sep 13, 2022
e1b0c48
src: make NearHeapLimitCallback() more robust
joyeecheung Sep 13, 2022
c32f7d6
build: remove redundant entry in crypto
gengjiawen Sep 14, 2022
d23ebfe
src: make ReqWrap weak
RafaelGSS Sep 14, 2022
e8a7ca5
doc: remove empty line in YAML block
ovflowd Sep 14, 2022
ee3c104
fs: remove unused option in `fs.fstatSync()`
LiviaMedeiros Sep 14, 2022
8870c74
doc: use serial comma in stream docs
daeyeon Sep 14, 2022
9afeb14
test_runner: include stack of uncaught exceptions
MoLow Sep 14, 2022
b57a86a
src: avoid copy when creating Blob
tniessen Sep 14, 2022
ccb9119
test: fix `test-repl` not validating leaked globals properly
aduh95 Sep 14, 2022
fbd86cb
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.1.0
nodejs-github-bot Sep 15, 2022
40958ab
doc: use serial comma in report docs
daeyeon Sep 15, 2022
8ae2991
tools: update eslint to 8.23.1
nodejs-github-bot Sep 15, 2022
d4b594a
meta: update test_runner in label-pr-config
shrujalshah28 Sep 15, 2022
6f75c16
doc: remove comma in README.md
Taha-Chaudhry Sep 15, 2022
92135bb
lib,test: fix bug in InternalSocketAddress
tniessen Sep 15, 2022
3d3292d
tls: fix out-of-bounds read in ClientHelloParser
tniessen Sep 15, 2022
5b4824c
doc,inspector: document changes of inspector.close
legendecas Sep 13, 2022
88a8296
test: improve lib/readline.js coverage
fossamagna Sep 15, 2022
3467ef3
tools: add timezone update workflow
98lenvi Sep 15, 2022
fb9ba7d
tools: fix typo in update-nghttp2.sh
lpinca Sep 16, 2022
3e1ebf1
doc: add legendecas to TSC list
mhdawson Sep 15, 2022
4c626d1
test: fix test-performance-measure
smitley Sep 14, 2022
c320d16
doc: maintain only one list of MODP groups
tniessen Sep 17, 2022
a0fbd95
doc: improve building doc for Windows Powershell
bmuenzenmeyer Sep 13, 2022
58732dc
deps: upgrade npm to 8.19.2
npm-cli-bot Sep 17, 2022
5f6ac6e
doc: make legacy banner slightly less bright
Trott Sep 17, 2022
7695a07
meta: move dnlup to emeriti
dnlup Sep 18, 2022
50ca02c
http: throw error on content-length mismatch
sidwebworks Aug 24, 2022
91b3999
deps: update ngtcp2 update instructions
tniessen Sep 18, 2022
7bb59c6
deps: update corepack to 0.14.1
nodejs-github-bot Sep 18, 2022
1194bae
module: open stat/readPackage to mutations
arcanis Sep 18, 2022
220f555
deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0
tniessen Sep 18, 2022
1a38b30
src: remove <unistd.h> from node_os.cc
tniessen Sep 18, 2022
9daadb5
meta: update AUTHORS
nodejs-github-bot Sep 18, 2022
765d4fb
tools: add update-llhttp.sh
ShogunPanda Sep 15, 2022
90fd063
meta: add mailmap entry for dnlup
Trott Sep 19, 2022
0153a83
esm,loader: tidy ESMLoader internals
JakobJingleheimer Sep 19, 2022
ec232dc
doc: remove extra space on threadpool usage
connorjburton Sep 20, 2022
5551c83
doc: mention where to push security commits
RafaelGSS Sep 16, 2022
40bc300
gyp: libnode for ios app embedding
chexiongsheng Sep 21, 2022
b5dffba
src: avoid using v8 on Isolate termination
santigimeno Sep 21, 2022
b54d100
doc: include code examples for webstreams consumers
khaosdoctor Aug 24, 2022
f8e9dd8
benchmark: fix startup benchmark
evanlucas Sep 21, 2022
fa05d90
doc,crypto: cleanup removed pbkdf2 behaviours
panva Sep 22, 2022
34b7f90
util: increase robustness with primordials
ljharb Sep 22, 2022
531a0e4
doc: add registry number for Electron 22
VerteDinde Sep 23, 2022
ca34771
test: change promise to async/await in debugger-watcher
Pooja444 Sep 16, 2022
d63ad83
doc: update guidance for adding new modules
mhdawson Sep 8, 2022
c9c70d1
http: disable chunked encoding when OBS fold is used
ShogunPanda Sep 19, 2022
702c496
doc: update the deprecation for exit code to clarify its scope
daeyeon Sep 24, 2022
85f2250
meta: update AUTHORS
nodejs-github-bot Sep 25, 2022
99a58b0
test: check that sysconf returns a positive value
tniessen Sep 25, 2022
2a02416
test: update test-debugger-low-level to use await/async
ml7181 Sep 25, 2022
6fbaaac
test: use async/await in test-debugger-invalid-args
nupurchauhan6 Sep 25, 2022
913e05e
doc: fix v16.17.1 security release changelog
ruyadorno Sep 25, 2022
96440bf
doc: fix description for `napi_get_cb_info()` in `n-api.md`
daeyeon Sep 26, 2022
318ecd2
test: change promises to async/await
MadhulikaSharma95 Sep 26, 2022
14cabfc
fs: fix typo in mkdir example
SergeyTsukanov Sep 26, 2022
8b0b23c
test: verify napi_remove_wrap with napi_delete_reference
legendecas Sep 26, 2022
50c3685
doc: ensure to revert node_version changes
RafaelGSS Sep 23, 2022
06e3349
doc: mention git node backport
RafaelGSS Sep 23, 2022
e33a449
tools: update lint-md-dependencies to rollup@2.79.1
nodejs-github-bot Sep 26, 2022
67cd9ba
tools: update eslint to 8.24.0
nodejs-github-bot Sep 27, 2022
db5b72f
path: change basename() argument from ext to suffix
Trott Sep 27, 2022
47d08f3
tools: update eslint-check.js to object style
Sep 27, 2022
9f3f417
test: change the promises to async/await in test-debugger-exec-scope.js
Ankita-Khiratkar Sep 27, 2022
d130d51
test: use async/await in test-debugger-profile
surbhirjain Sep 27, 2022
cca6b12
test: use async/await in test-debugger-preserve-breaks
poorvitusam Sep 27, 2022
6f9fe30
test: update test-debugger-breakpoint-exists.js to use async/await
archana-kamath Sep 27, 2022
83c65ab
build: update timezone-update.yml
sashashura Sep 19, 2022
6614225
test: modify test-debugger-custom-port.js to use async-await
pshastricb Sep 27, 2022
5cbb6a8
doc: remove "currently" and comma splice from child_process.md
Trott Sep 27, 2022
6ec5ef6
tools: refactor deprecated format in no-unescaped-regexp-dot
sonimadhuri Sep 27, 2022
d6b602a
esm: fix duplicated test
GeoffreyBooth Sep 28, 2022
078ecbe
test: refactor to async/await
DivyaMohan94 Sep 28, 2022
3833f31
bootstrap: update comments in bootstrap/node.js
joyeecheung Sep 19, 2022
46e5907
child_process: remove lookup of undefined property
cjihrig Sep 24, 2022
b0ea3de
fs: don't hard code name in validatePosition()
cjihrig Sep 24, 2022
b3ce013
test: add extra tests for basename with ext option
connorjburton Sep 29, 2022
7de6aa7
test: use async/await in test-debugger-sb-before-load
hopeolaide Sep 29, 2022
4c40de2
test: change promises to async/await in test-debugger-backtrace.js
zhangjuliet Sep 29, 2022
264518b
test: migrated from Promise chains to Async/Await
rathi2016 Sep 29, 2022
27c27c6
src: remove ParseIP() in cares_wrap.cc
tniessen Sep 29, 2022
4073de6
test: use async/await in test-debugger-auto-resume
samyuktaprabhu Sep 16, 2022
24704b9
crypto: use EVP_PKEY_CTX_set_dsa_paramgen_q_bits when available
davidben Sep 29, 2022
80b38ca
node-api: add deprecation code of uncaught exception
legendecas Sep 13, 2022
4b9a2e3
test: don't clobber RegExp.$_ on startup
bnoordhuis Oct 7, 2022
63f9a51
test: update WPT runner
panva Aug 10, 2022
0ea9df3
crypto: fix webcrypto generateKey() AES key length validation error
panva Aug 8, 2022
99c78d6
crypto: fix webcrypto operation errors to be OperationError
panva Aug 12, 2022
5cc2b8a
crypto: fix webcrypto EC key namedCurve validation errors
panva Aug 8, 2022
9005210
crypto: fix webcrypto deriveBits validations
panva Aug 8, 2022
a71a9ff
crypto: allow zero-length secret KeyObject
panva Aug 11, 2022
689a7f8
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2
panva Aug 11, 2022
7e8e093
test,crypto: update WebCryptoAPI WPT
panva Aug 14, 2022
bdc8758
tools: increase timeout of running WPT
joyeecheung Sep 11, 2022
54a488d
2022-10-12, Version 16.18.0 'Gallium' (LTS)
juanarbol Oct 11, 2022
63bd402
Working on v16.18.1
juanarbol Oct 12, 2022
0e9ffa1
inspector: harden IP address validation again
tniessen Sep 25, 2022
72c7417
2022-11-04, Version 16.18.1 'Gallium' (LTS)
BethGriggs Nov 1, 2022
3742a46
Working on v16.18.2
BethGriggs Nov 4, 2022
8a10c4a
build: fix bad upstream merge
sgallagher Sep 14, 2022
6377763
test: update list of known globals
aduh95 Oct 31, 2022
2d087e6
deps: update corepack to 0.14.2
nodejs-github-bot Oct 8, 2022
4dbbf9d
deps: update undici to 5.11.0
nodejs-github-bot Oct 9, 2022
821cfb4
deps: update timezone
nodejs-github-bot Oct 18, 2022
fb713ad
build: remove redundant condition from common.gypi
richardlau Oct 19, 2022
ae5115a
deps: upgrade openssl sources to OpenSSL_1_1_1s
RafaelGSS Nov 1, 2022
aefcea4
deps: update archs files for OpenSSL-1.1.1s
RafaelGSS Nov 1, 2022
fbcadfe
readline: refactor to avoid unsafe regex primordials
aduh95 Oct 8, 2022
9b798ba
tools: refactor `avoid-prototype-pollution` lint rule
aduh95 Jun 17, 2022
848ff9f
tools: fix typo in `avoid-prototype-pollution` lint rule
aduh95 Aug 30, 2022
009d10b
tools: make license-builder.sh comply with shellcheck 0.8.0
Trott Dec 22, 2021
d5f2961
tools: have test-asan use ubuntu-20.04
panva Nov 22, 2022
8631c77
cli: add `--watch`
MoLow Oct 3, 2022
e4d5211
test: split watch mode inspector tests to sequential
MoLow Oct 3, 2022
f8bdc2e
test: deflake watch mode tests
MoLow Oct 3, 2022
fb703a7
test: fix watch mode test flake
MoLow Oct 3, 2022
03c5a3a
deps: update undici to 5.12.0
nodejs-github-bot Oct 30, 2022
5a69a0d
test: fix textdecoder test for small-icu builds
richardlau Oct 30, 2022
09cff6c
deps: V8: cherry-pick b95354290941
legendecas Oct 10, 2022
90fca00
deps: V8: backport bbd800c6e359
legendecas Oct 10, 2022
a7c5bed
src: split property helpers from node::Environment
legendecas Aug 1, 2022
24dc964
deps: update corepack to 0.15.0
nodejs-github-bot Oct 30, 2022
5a90899
deps: update corepack to 0.15.1
nodejs-github-bot Nov 7, 2022
445d96f
deps: upgrade npm to 8.19.3
npm-cli-bot Nov 7, 2022
cd41356
node-api: handle no support for external buffers
mhdawson Oct 25, 2022
12f105f
build: support Python 3.11
lpinca Oct 26, 2022
5d5d14c
tools: use Python 3.11 in GitHub Actions workflows
lpinca Oct 26, 2022
b128f30
util: add default value option to parsearg
Eomm Oct 7, 2022
e95e6c8
doc: fix typo in parseArgs default value
tniessen Oct 20, 2022
a3a152d
dgram: add dgram send queue info
theanarkh Aug 17, 2022
8a2ab64
build: add version info to timezone update PR
RaisinTen Oct 18, 2022
5c81857
tools: update gr2m/create-or-update-pull-request-action
lpinca Oct 19, 2022
d987f54
tools: fix `create-or-update-pull-request-action` hash on GHA
aduh95 Oct 25, 2022
884b2ef
test: add a test to ensure the correctness of timezone upgrades
RaisinTen Nov 10, 2022
f25536d
tools: fix timezone update tool
RaisinTen Oct 3, 2022
5954779
tools: remove faulty early termination logic from update-timezone.mjs
RaisinTen Oct 3, 2022
3cfa76d
deps: update timezone to 2022f
richardlau Nov 24, 2022
a0df862
test_runner: support programmatically running `--test`
MoLow Oct 3, 2022
b46081b
test_runner: fix `duration_ms` to be milliseconds
MoLow Oct 3, 2022
f77d7b7
test_runner: support using `--inspect` with `--test`
MoLow Oct 3, 2022
2dcd0bf
test: fix test-runner-inspect
MoLow Oct 3, 2022
2a9fa79
cluster: use inspector utils
MoLow Sep 13, 2022
7a6fc92
test: mark test-watch-mode* as flaky on all platforms
pbo-linaro Oct 20, 2022
6c6fd91
tools: update certdata.txt
lpinca Nov 16, 2022
dd2d8bf
crypto: update root certificates
lpinca Nov 16, 2022
b636f7d
test: add test to validate changelogs for releases
richardlau Nov 15, 2022
07bb1d8
src: let http2 streams end after session close
santigimeno Oct 27, 2022
0f7e779
src: disambiguate terms used to refer to builtins and addons
joyeecheung Aug 4, 2022
fe4ffed
2022-12-13, Version 16.19.0 'Gallium' (LTS)
richardlau Dec 8, 2022
62352ee
src: adjust property helpers usage
guangwong Jan 3, 2023
37626df
src: enable CPU affinity for Node main thread to avoid context switch
lucshi Mar 3, 2023
f1ea7ac
src: update CPU affinity patch
lucshi Mar 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ tools/icu
tools/lint-md/lint-md.mjs
benchmark/tmp
doc/**/*.js
!doc/api_assets/*.js
!.eslintrc.js
2 changes: 2 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ module.exports = {
'no-useless-concat': 'error',
'no-useless-constructor': 'error',
'no-useless-return': 'error',
'no-var': 'error',
'no-void': 'error',
'no-whitespace-before-property': 'error',
'object-curly-newline': 'error',
Expand Down Expand Up @@ -319,6 +320,7 @@ module.exports = {
'node-core/no-duplicate-requires': 'error',
},
globals: {
CustomEvent: 'readable',
Crypto: 'readable',
CryptoKey: 'readable',
fetch: 'readable',
Expand Down
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
test/fixtures/* -text
vcbuild.bat text eol=crlf
deps/npm/bin/npm text eol=lf
deps/npm/bin/npx text eol=lf
deps/corepack/shims/corepack text eol=lf
tools/msvs/find_python.cmd text eol=crlf
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
/benchmark/misc/startup.js @nodejs/startup
/src/node.cc @nodejs/startup
/src/node_code_cache_stub.cc @nodejs/startup
/src/node_native_module* @nodejs/startup
/src/node_builtins* @nodejs/startup
/src/node_snapshot* @nodejs/startup
/lib/internal/bootstrap/* @nodejs/startup
/tools/code_cache/* @nodejs/startup
/tools/snapshot/* @nodejs/startup
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ body:
label: Platform
description: |
UNIX: output of `uname -a`
Windows: output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console
Windows: output of `"$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"` in PowerShell console
- type: input
attributes:
label: Subsystem
Expand Down
17 changes: 15 additions & 2 deletions .github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,24 @@ body:
placeholder: e.g. `test-fs-stat-bigint`
validations:
required: true
- type: input
- type: dropdown
attributes:
label: Platform
description: The platform the test is flaky on.
placeholder: e.g. `macos` or `linux`
multiple: true
options:
- AIX
- FreeBSD
- Linux ARM64
- Linux ARMv7
- Linux PPC64LE
- Linux s390x
- Linux x64
- macOS ARM64
- macOS x64
- SmartOS
- Windows
- Other
- type: textarea
attributes:
label: Console output
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
blank_issues_enabled: false
blank_issues_enabled: true
contact_links:
- name: ⁉️ Need help with Node.js?
url: https://github.com/nodejs/help
Expand Down
10 changes: 7 additions & 3 deletions .github/label-pr-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ subSystemLabels:
/^src\/.*win32.*/: c++, windows
/^src\/node_zlib/: c++, zlib
/^src\/tracing/: c++, tracing
/^src\/node_api/: c++, node-api
/^src\/(?:node_api|js_native_api)/: c++, node-api
/^src\/node_http2/: c++, http2
/^src\/node_report/: c++, report
/^src\/node_wasi/: c++, wasi
Expand Down Expand Up @@ -67,7 +67,7 @@ subSystemLabels:
/^tools\/make-v8/: tools, v8 engine, needs-ci
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
/^tools\/(code_cache|snapshot)/: needs-ci
/^tools\/build-addons.js/: needs-ci
/^tools\/build-addons.mjs/: needs-ci
# all other tool changes should be marked as such
/^tools\//: tools
/^\.eslint|\.remark|\.editorconfig/: tools
Expand Down Expand Up @@ -101,6 +101,8 @@ subSystemLabels:
/^lib\/worker_threads.js$/: worker
/^lib\/internal\/url\.js$/: whatwg-url
/^lib\/internal\/modules\/esm/: esm
/^lib\/internal\/webstreams/: web streams
/^lib\/internal\/test_runner/: dont-land-on-v14.x

# All other lib/ files map directly
/^lib\/_(\w+)_\w+\.js?$/: $1 # e.g. _(stream)_wrap
Expand All @@ -117,11 +119,13 @@ exlusiveLabels:
/^test\/inspector\//: test, inspector
/^test\/cctest\/test_inspector/: test, inspector
/^test\/cctest\/test_url/: test, whatwg-url
/^test\/addons-napi\//: test, node-api
/^test\/node-api\//: test, node-api
/^test\/js-native-api\//: test, node-api
/^test\/async-hooks\//: test, async_hooks
/^test\/report\//: test, report
/^test\/fixtures\/es-module/: test, esm
/^test\/es-module\//: test, esm
/^test\/fixtures\/wpt\/streams//: test, web streams

/^test\//: test

Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,30 @@ on:

workflow_dispatch:

permissions:
contents: read

jobs:
authors_update:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: '0' # This is required to actually get all the authors
persist-credentials: false
- run: tools/update-authors.js # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@v1 # Create a PR or update the Action's existing PR
- run: tools/update-authors.mjs # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
body: >
Here are some new additions to the AUTHORS file.
This is an automatically generated PR by the
`authors.yml` GitHub Action, which runs `tools/update-authors.js`.
`authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
branch: actions/authors-update # Custom branch *just* for this Action.
commit-message: 'meta: update AUTHORS'
labels: meta
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ concurrency: ${{ github.workflow }}
env:
NODE_VERSION: lts/*

permissions:
contents: read

jobs:
get-prs-for-ci:
permissions:
pull-requests: read
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
outputs:
Expand All @@ -32,16 +37,19 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
start-ci:
permissions:
contents: read
pull-requests: write
needs: get-prs-for-ci
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
24 changes: 13 additions & 11 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- '!.github/workflows/build-tarball.yml'
push:
branches:
- master
- main
- v[0-9]+.x-staging
- v[0-9]+.x
Expand All @@ -29,19 +28,22 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.10'
FLAKY_TESTS: dontcare
PYTHON_VERSION: '3.11'
FLAKY_TESTS: keep_retrying

permissions:
contents: read

jobs:
build-tarball:
if: github.event.pull_request.draft == false
if: github.event.pull_request.draft == false && false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -55,25 +57,25 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: tarballs
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
with:
name: tarballs
path: tarballs
Expand All @@ -92,4 +94,4 @@ jobs:
- name: Test
run: |
cd $TAR_DIR
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
14 changes: 8 additions & 6 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
Expand All @@ -24,19 +23,22 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.10'
FLAKY_TESTS: dontcare
PYTHON_VERSION: '3.11'
FLAKY_TESTS: keep_retrying

permissions:
contents: read

jobs:
build-windows:
if: github.event.pull_request.draft == false
if: github.event.pull_request.draft == false && false
runs-on: windows-2019
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
17 changes: 10 additions & 7 deletions .github/workflows/close-stale-feature-requests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
name: Close stale feature requests
on:
workflow_dispatch:
inputs:
daysBeforeStale:
description: Idle number of days before marking feature requests stale
required: true
default: 906
type: number
schedule:
# Run every day at 1:00 AM UTC.
- cron: 0 1 * * *

# yamllint disable rule:empty-lines
env:
Expand All @@ -31,15 +28,21 @@ env:
[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md).
# yamllint enable

permissions:
contents: read

jobs:
stale:
permissions:
issues: write # for actions/stale to close stale issues
pull-requests: write # for actions/stale to close stale PRs
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v4
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: ${{ github.event.inputs.daysBeforeStale }}
days-before-stale: 180
days-before-close: 30
stale-issue-label: stale
close-issue-message: ${{ env.CLOSE_MESSAGE }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ env:
is still relevant, or to ping the collaborator who labelled it stalled if
you have any questions.

permissions:
contents: read

jobs:
stale:
permissions:
issues: write # for actions/stale to close stale issues
pull-requests: write # for actions/stale to close stale PRs
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/comment-labeled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@ env:
If it should remain open, please leave a comment explaining why it should remain open.
FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.

permissions:
contents: read

jobs:
stale-comment:
permissions:
issues: write
pull-requests: write
if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
runs-on: ubuntu-latest
steps:
Expand All @@ -23,6 +29,8 @@ jobs:
run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"

fast-track:
permissions:
pull-requests: write
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
runs-on: ubuntu-latest
steps:
Expand Down
Loading