Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update sign.md for OCI image manifest support #540

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Feb 7, 2023

updates:

  • Update the flag name per community discussion
  • Update the description for using OCI image manifest

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #540 (2c09b5e) into main (4f573af) will not change coverage.
The diff coverage is n/a.

❗ Current head 2c09b5e differs from pull request most recent head 1e21372. Consider uploading reports for the commit 1e21372 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files          30       30           
  Lines        1607     1607           
=======================================
  Hits          584      584           
  Misses       1002     1002           
  Partials       21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 86aeb0c into notaryproject:main Feb 9, 2023
@yizha1 yizha1 deleted the update-flag branch February 9, 2023 14:29
priteshbandi pushed a commit that referenced this pull request Feb 10, 2023
After discussion with @yizha1, aligning with the spec in this [PR](#540).

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants