Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sign command descriptions to align with the spec #543

Merged
merged 2 commits into from Feb 10, 2023

Conversation

patrickzheng200
Copy link
Contributor

After discussion with @yizha1, aligning with the spec in this PR.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 self-assigned this Feb 9, 2023
@patrickzheng200 patrickzheng200 added the UX User experience changes label Feb 9, 2023
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #543 (5913944) into main (4f573af) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files          30       30           
  Lines        1607     1607           
=======================================
  Hits          584      584           
  Misses       1002     1002           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/notation/sign.go 40.18% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit c47a452 into notaryproject:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants