New tool to rename notebooks #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mbektas |
mbektas
reviewed
Aug 16, 2025
| new_name: New name for the notebook | ||
| """ | ||
| response = args["response"] | ||
| ui_cmd_response = await response.run_ui_command('notebook-intelligence:rename-notebook-from-py', {'newName': new_name}) |
There was a problem hiding this comment.
can you remove -from-py suffix from the command names
mbektas
reviewed
Aug 16, 2025
src/index.ts
Outdated
| @@ -87,6 +87,8 @@ namespace CommandIDs { | |||
| export const createNewFile = 'notebook-intelligence:create-new-file'; | |||
| export const createNewNotebookFromPython = | |||
| 'notebook-intelligence:create-new-notebook-from-py'; | |||
| export const renameNotebookFromPython = | |||
There was a problem hiding this comment.
FromPython in name is not necessary
mbektas
reviewed
Aug 16, 2025
src/index.ts
Outdated
| const activeWidget = app.shell.currentWidget; | ||
| if (activeWidget instanceof NotebookPanel) { | ||
| const oldPath = activeWidget.context.path; | ||
| const newPath = args.newName as string; |
There was a problem hiding this comment.
I think the new name should be input as just file name and it shouldn't change the parent directory of a notebook. example:
- oldPath: 'test/untitled.ipynb'
- newName: 'hello-world'
- newPath: 'test/hello-world.ipynb'
|
done with the changes, please have a look. @mbektas |
mbektas
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple tool addition to rename notebooks