Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace old config and allow initialization configuration #426

merged 1 commit into from Aug 12, 2022


Copy link

@0xpr03 0xpr03 commented Aug 10, 2022

Removes all event-level configuration, which is completely unimplemented by all backends.
Replaces them with the init-critical PollWatcher config. Allows configuration during initialization. Uses a builder pattern with defaults to allow future settings.

This way you can setup a recommended watcher while still specifying the wanted PollWatcher settings and the debouncer can initiate a PollWatcher with compare_contents, something that can only be done pre runtime.

Related #249
Closes #418

@0xpr03 0xpr03 force-pushed the remove_live_config branch 2 times, most recently from bf9b6e9 to b1e8bac Compare August 10, 2022 14:12
@0xpr03 0xpr03 added this to the 5.0.0 milestone Aug 10, 2022
@0xpr03 0xpr03 force-pushed the remove_live_config branch 4 times, most recently from 9dc36f4 to 8682510 Compare August 10, 2022 14:33
@0xpr03 0xpr03 marked this pull request as ready for review August 10, 2022 14:39
@0xpr03 0xpr03 requested a review from JohnTitor August 10, 2022 14:39
Copy link

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


This also allows correct configuration of PollWatcher via notify-debouncer-mini
@0xpr03 0xpr03 merged commit 29376ad into main Aug 12, 2022
12 checks passed
@0xpr03 0xpr03 deleted the remove_live_config branch August 18, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Consider use dedicated configuration interface for every single watcher implementation.
2 participants