Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1434 #1435

Closed
wants to merge 1 commit into from
Closed

fix issue #1434 #1435

wants to merge 1 commit into from

Conversation

mqklin
Copy link
Contributor

@mqklin mqklin commented Jan 12, 2016

It may be a breaking change, but I think it's better than having a bug.

@mgalloue
Copy link
Contributor

+1

@mgalloue
Copy link
Contributor

Hi @mqklin which chart are you using? Can you check if the fix done in this PR can fix your problem?

Regards

@mqklin
Copy link
Contributor Author

mqklin commented Jan 19, 2016

I use multibarchart and horizontal multibarchart, I'll check it tomorrow

@liquidpele
Copy link
Contributor

No, I specifically added the width and height so that it would by default take up the whole svg... this allows the svg to scale with the page easily without having to calculate height and width every time.

@liquidpele liquidpele closed this Jan 24, 2016
@liquidpele
Copy link
Contributor

I merged the height/width options that @mgalloue added... if you use those then it should override the default CSS... unless that part is broken :/

@mqklin
Copy link
Contributor Author

mqklin commented Jan 26, 2016

@liquidpele , but look at this screen! Styles from .css file have bigger priority than svg[Attributes Style]!
Look at jsfiddle example!
If you want to set width and height as 100% you should do it through svg[Attributes Style] as well!

@mqklin
Copy link
Contributor Author

mqklin commented Jan 26, 2016

@liquidpele , it is possible to set chart.width with not only unitless? e.g. chart.width("10em") ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants