[BUG] npm-version does not git-commit nor git-tag when package in subdirectory

[jasonkarns]

Current Behavior:

npm version <version> is not committing the modified package.json or package-lock.json; nor git-tagging.

We were using npm version {major|minor|patch} extensively (and successfully). It stopped working once the package was moved out of the root of the repo and into a subdirectory.

Expected Behavior:

npm version <version> should continue to create a git-commit and git-tag as indicated in the docs:

If run in a git repo, it will also create a version commit and tag. This behavior is controlled by git-tag-version (see below), and can be disabled on the command line by running npm --no-git-tag-version version. It will fail if the working directory is not clean, unless the -f or --force flag is set.

Steps To Reproduce:

1. initialize an npm package in the root of an initialized git repo
2. npm version minor successfully bumps the version, commits and tags
3. move the npm package into a subdirectory of the repo
4. npm version minor still bumps the version in package.json and package-lock.json, but git is not committed nor tagged.

Environment:

• macOS 10.15.7
• node: v14.13.1
• npm: 6.14.8
• git: git version 2.28.0

This is apparently an existing bug going as far back as npm v3: npm/npm#18795

[niedzielski]

I just hit this issue using NPM workspaces on Node v15.2.1 / NPM v7.0.8 for Ubuntu. The problem may become more popular with workspaces containing independently versioned packages as they tend to use subdirectories.

[ljharb]

@niedzielski does it still occur with v7.0.15?

[niedzielski]

@ljharb, yes. I can repro on NPM v7.0.15. Using a local installation of NPM:

../node_modules/.bin/npm version prerelease --preid=foo

Changes the package version in my repo to 3.0.1-foo.0 but doesn't commit the change. Explicitly setting --git-tag-version=true also has no effect.

[amoscatelli]

This still occours in 7.5.4

[darcyclarke]

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

[ljharb]

Reopening; latest comment suggests it's still an issue in npm 7.