Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm_command env not getting set #2015

Closed
isaacs opened this issue Oct 22, 2020 · 0 comments
Closed

[BUG] npm_command env not getting set #2015

isaacs opened this issue Oct 22, 2020 · 0 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@isaacs
Copy link
Contributor

isaacs commented Oct 22, 2020

At some point in the v7 beta/rc line, we shuffled around the order of when configs are loading and envs are set, and ended up clobbering the npm_command environment variable.

Current Behavior:

{
  "name": "test-command-env",
  "version": "1.0.0",
  "scripts": {
    "test": "echo $npm_command"
  }
}
$ npm test

> test-command-env@1.0.0 test
> echo $npm_command

null

Expected Behavior:

$ npm test

> test-command-env@1.0.0 test
> echo $npm_command

test
@isaacs isaacs added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Needs Triage needs review for next steps labels Oct 22, 2020
isaacs added a commit that referenced this issue Oct 22, 2020
isaacs added a commit that referenced this issue Oct 22, 2020
isaacs added a commit that referenced this issue Oct 22, 2020
isaacs added a commit that referenced this issue Oct 22, 2020
isaacs added a commit that referenced this issue Oct 22, 2020
@isaacs isaacs closed this as completed in 59e8dd6 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant