Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ls test snapshots #4776

Merged
merged 1 commit into from
Apr 19, 2022
Merged

chore: ls test snapshots #4776

merged 1 commit into from
Apr 19, 2022

Conversation

wraithgar
Copy link
Member

tap snapshots don't fail if there are extra snapshots that aren't
evaluated during the course of a test. There were tests removed in
#4744 that didn't get removed from
snapshots.

This removes those snapshots

tap snapshots don't fail if there are extra snapshots that aren't
evaluated during the course of a test.  There were tests removed in
#4744 that didn't get removed from
snapshots.

This removes those snapshots
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 57.359 ±1.10 33.738 ±0.44 29.300 ±11.27 23.829 ±0.80 3.368 ±0.06 3.372 ±0.01 2.762 ±0.07 14.370 ±0.13 2.687 ±0.01 3.876 ±0.21
#4776 62.254 ±4.34 34.163 ±0.23 21.265 ±0.07 24.216 ±0.38 3.406 ±0.03 3.442 ±0.06 2.777 ±0.06 14.408 ±0.12 2.746 ±0.02 3.967 ±0.12
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.008 ±3.34 33.680 ±11.48 14.908 ±0.02 16.347 ±0.06 3.085 ±0.02 3.092 ±0.01 2.828 ±0.16 10.148 ±0.02 2.598 ±0.04 3.522 ±0.09
#4776 43.432 ±3.08 26.018 ±0.02 15.274 ±0.10 16.483 ±0.42 3.106 ±0.01 3.116 ±0.02 2.821 ±0.09 10.227 ±0.04 2.610 ±0.01 3.528 ±0.13

@lukekarrys lukekarrys merged commit 4a46a27 into latest Apr 19, 2022
@lukekarrys lukekarrys deleted the gar/ls-snap branch April 19, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants