Skip to content

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 29, 2025

Spelling errors hurt usability/readability

References

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner September 29, 2025 01:21
@wraithgar wraithgar changed the title chore: Fix spelling in docs docs: Fix spelling Sep 29, 2025
/* return dependencies that have a testling config for opera browsers */
*:attr(testling, browsers, [~=opera])
/* return dependencies that have a testing config for opera browsers */
*:attr(testing, browsers, [~=opera])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be inclined to do this:

/* return dependencies that have a [testling config](https://ci.testling.com/guide/advanced_configuration) for opera browsers */

But, that's outside the scope of this PR. I'll drop the commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you. I know you're trying to focus on small PRs but you don't have to do that for our sake. It's relatively easy to review docs updates like this so don't avoid combining more changes for our sake. Whatever's easiest for you.

jsoref and others added 3 commits September 29, 2025 17:46
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Gar <wraithgar@github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@wraithgar wraithgar merged commit 1b0429a into npm:latest Sep 30, 2025
8 checks passed
@jsoref jsoref deleted the spelling-docs branch September 30, 2025 12:22
@jsoref jsoref mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants