-
Notifications
You must be signed in to change notification settings - Fork 3.7k
docs: Fix spelling #8607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix spelling #8607
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
/* return dependencies that have a testling config for opera browsers */ | ||
*:attr(testling, browsers, [~=opera]) | ||
/* return dependencies that have a testing config for opera browsers */ | ||
*:attr(testing, browsers, [~=opera]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was not a typo https://ci.testling.com/guide/advanced_configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be inclined to do this:
/* return dependencies that have a [testling config](https://ci.testling.com/guide/advanced_configuration) for opera browsers */
But, that's outside the scope of this PR. I'll drop the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you. I know you're trying to focus on small PRs but you don't have to do that for our sake. It's relatively easy to review docs updates like this so don't avoid combining more changes for our sake. Whatever's easiest for you.
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Gar <wraithgar@github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
c9c41fd
to
57705cc
Compare
Spelling errors hurt usability/readability
References