-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: typo bugs and other spelling fixes #8621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
d4adc19
to
2e19606
Compare
First and foremost, this work is already important on its own. Fixing readability in comments and code is important. Thank you. BUT. In a classic case of curb cutting, you also found two bugs while doing this. Great job. We'll have to work through what tests are failing now and why, but at this point we can assume the tests are wrong since it was a code fix that made them start failing. |
workspaces/arborist/test/fixtures/registry-mocks/content/set-value.json
Outdated
Show resolved
Hide resolved
Can we revert the changes in the registry mocks? Those are fixtures pulled from the registry itself. |
2e19606
to
7517783
Compare
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
7517783
to
9b34d43
Compare
Fwiw, I think most of the test failures were me doing a not great job splitting some commits across subtrees and occasionally making last minute changes -- classic ways I mess up. Thankfully the ci is reasonably friendly. If I could more easily run it in my forks, I wouldn't have included them in the PRs, but almost all of the ci actively suppresses itself in forks. I appreciate the concern it has for fork resources. And yes, if I really really wanted to I could have changed the CI to run in my forks, but I decided that this org wanted me to do PRs publicly, so I left things as is. My only complaint about the failures is that I didn't immediately know to search for
... once at the very end. As someone who does a lot of drive-by contributing to many disparate ecosystems, this tends to be one of the things I wish everyone did a better job of instead of assuming that all users would know the proper magical search term for their specific CI tool. |
This is a great suggestion. Unfortunately it's not something I know how to do easily given the current testing setup. We'd either have to create a custom test script that calls the real tests, and outputs something specific on error. Or we'd have to write a custom reporter for tap. Neither of those seems very elegant or practical. Those |
Fixes two typo-related bugs: