Skip to content

fix: tag heading levels properly #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2024
Merged

fix: tag heading levels properly #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a96eb87
Bug fix for #9219 & #9186
kartykp Nov 14, 2024
5c9401d
Revert "Bug fix for #9219 & #9186"
kartykp Nov 15, 2024
ec7fab8
Bug fix for #9186
kartykp Nov 15, 2024
abc8cee
Revert "Bug fix for #9186"
kartykp Nov 26, 2024
3317c2d
Accessibility fix
kartykp Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/table-of-contents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const Desktop = withTableOfContents(({items}) => (
maxHeight: `calc(100vh - ${SCROLL_MARGIN_TOP}px)`,
}}
>
<Heading as="h3" sx={{fontSize: 1, display: 'inline-block', fontWeight: 'bold'}} id="toc-heading">
<Heading as="h2" sx={{fontSize: 1, display: 'inline-block', fontWeight: 'bold'}} id="toc-heading">
Table of contents
</Heading>
<Box
Expand Down
8 changes: 4 additions & 4 deletions src/mdx/components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ const Headings = {

export const H1 = Headings.wrap('h1')
export const H2 = Headings.wrap('h2')
export const H3 = Headings.wrap('h3')
export const H4 = Headings.wrap('h4')
export const H5 = Headings.wrap('h5')
export const H6 = Headings.wrap('h6')
export const H3 = Headings.wrap('h2')
export const H4 = Headings.wrap('h3')
export const H5 = Headings.wrap('h4')
export const H6 = Headings.wrap('h5')

export const Blockquote = styled.blockquote`
margin: 0 0 ${themeGet('space.3')};
Expand Down
Loading