Skip to content

Conversation

jpg619
Copy link
Contributor

@jpg619 jpg619 commented Sep 22, 2025

📁 File Changes (5 files modified):

  • nav-drawer.js - Added focus-visible styles to mobile menu button
  • search.js - Added focus-visible styles to mobile search button
  • table-of-contents.js - Added focus-visible styles to mobile TOC summary button
  • variant-select.js - Added focus-visible styles to CLI version selector button
  • code.js - Updated outlineOffset from 2px to 1px for clipboard copy button

📋 Summary:

This PR improves keyboard accessibility by adding consistent focus-visible outline styles to interactive buttons across mobile components, ensuring better visual feedback for keyboard navigation users.

Keyboard focus indicator is not visible on 'search' icon

image

Keyboard focus indicator is not visible on the 'Select CLI Version' button

image

Keyboard focus indicator is not visible on 'Table of contents

image

@jpg619 jpg619 changed the title [Fix Accessibility] Add focus-visible styles to Mobile Table of Content [Fix Accessibility] Add focus-visible styles to keyboard navigation Sep 22, 2025
@jpg619 jpg619 marked this pull request as ready for review September 22, 2025 19:31
@jpg619 jpg619 requested review from leobalter and a team as code owners September 22, 2025 19:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses accessibility issues by adding consistent focus-visible outline styles to keyboard navigation elements across mobile components, ensuring better visual feedback for users navigating with keyboards.

  • Added focus-visible outline styles to four mobile interactive buttons (menu, search, table of contents, CLI version selector)
  • Updated the clipboard copy button's outline offset from 2px to 1px for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
nav-drawer.js Added focus-visible styles to mobile menu button
search.js Added focus-visible styles to mobile search button
table-of-contents.js Added focus-visible styles to mobile TOC summary button
variant-select.js Added focus-visible styles to CLI version selector button
code.js Updated outline offset for clipboard copy button consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpg619 jpg619 merged commit 32c64a6 into main Sep 22, 2025
9 checks passed
@jpg619 jpg619 deleted the jpg619/fix-accessibility-keyboard-focus branch September 22, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants