Follow does not get propagated to child entries of dir reader #14

Open
satazor opened this Issue Aug 7, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@satazor

satazor commented Aug 7, 2013

getChildProps incorrectly sets the follow based on this.follow, shouldn't it be this.props.follow?
https://github.com/isaacs/fstream/blob/master/lib/dir-reader.js#L212

follow on this or me is not being set anywhere. This causes wrong behaviour when using follow: true on nested folders that have symlinks.

@AdamMagaluk

This comment has been minimized.

Show comment Hide comment
@AdamMagaluk

AdamMagaluk Oct 1, 2013

I'm seeing the same thing. Tested changing it to this.props.follow, causes it to to follow symbolic links in nested folders.

Is this the desired behavior or is it intended to not follow sym links in folders?

I'm seeing the same thing. Tested changing it to this.props.follow, causes it to to follow symbolic links in nested folders.

Is this the desired behavior or is it intended to not follow sym links in folders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment