fix: x-range partial version build metadata support #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Sep 24, 2025
wraithgar
reviewed
Sep 24, 2025
|
Ok now we're cooking. And the comment still describes what we're doing Build is not part of a comparator. |
wraithgar
changed the title
wraithgar
previously approved these changes
Sep 26, 2025
wraithgar
reviewed
Sep 26, 2025
|
Looks good. Those test cases probably should move to a test fixture file (i.e ./test/fixtures/range-build.js). I will merge this after the weekend regardless, we can make that change as a follow up if you don't want to. |
|
Moved the test cases to /test/fixtures/range-build.js . Thank you for your support and help. |
|
I cleaned up the test cases this morning and made #811, you are still listed as the actual author in git commit 94d2054633456bcd8fc3e1afa331bbeac3e215d0 (HEAD -> gar/pr810, origin/gar/pr810)
Author: i529015 <redacted>
Date: Wed Sep 24 13:21:26 2025 +0530
fix: x-range build metadata support
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting for partial version and x-range for build metadata.
bin/semver.js 1.3.4 -r ">=1.x+build <2.x+build"will work.Also checking and removing support for x-range pre-release.
bin/semver.js 1.3.4 -r ">=1.x.x-alpha <2.x+build"will not work.Closes: #509