Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct, lower length limit #9

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Use correct, lower length limit #9

merged 1 commit into from
Jun 20, 2016

Conversation

aredridel
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 20, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2242f72 on fix-length into ab80494 on master.

@aredridel
Copy link
Contributor Author

Turns out what's allowed is the same as validate-npm-package-name: 214 characters. The 576 character limit from the registry tables is much higher than needed.

@soldair
Copy link

soldair commented Jun 20, 2016

🐑

@aredridel aredridel merged commit 93c0d60 into master Jun 20, 2016
@aredridel aredridel deleted the fix-length branch June 20, 2016 15:27
iarna added a commit to npm/npm that referenced this pull request Jul 7, 2016
@iarna
npm-user-validate@0.1.5
c7567e5 
Lower the username length limits to 214 from 576 to bring in line with registry limits.

Credit: @aredridel
PR-URL: npm/npm-user-validate#9
iarna added a commit to npm/npm that referenced this pull request Aug 11, 2016
@iarna
npm-user-validate@0.1.5
d681e16 
Use correct, lower username length limit.

PR-URL: npm/npm-user-validate#9
Credit: @aredridel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soldair soldair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aredridel @coveralls @soldair