Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Remove two unused dependencies #12926

Closed
wants to merge 2 commits into from
Closed

Remove two unused dependencies #12926

wants to merge 2 commits into from

Conversation

mmalecki
Copy link
Contributor

@mmalecki mmalecki commented Jun 1, 2016

I was idly looking at the source and was surprised that we use those two, so I ack'd and it seems like we don't, so here's a PR.

@zkat zkat added this to the next milestone Jun 1, 2016
@zkat
Copy link
Contributor

zkat commented Jun 1, 2016

LGTM!

zkat pushed a commit that referenced this pull request Jun 2, 2016
@mmalecki @zkat
deps: remove unused lodash.keys
168ed28 
PR-URL: #12926
Credit: @mmalecki
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Jun 2, 2016
@mmalecki @zkat
deps: remove unused lodash.isarray
61c1d9c 
PR-URL: #12926
Credit: @mmalecki
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Jun 2, 2016
@mmalecki @zkat
deps: remove unused lodash.keys
d1a4ea9 
PR-URL: #12926
Credit: @mmalecki
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Jun 2, 2016
@mmalecki @zkat
deps: remove unused lodash.isarray
bbd88b5 
PR-URL: #12926
Credit: @mmalecki
Reviewed-By: @zkat
@zkat
Copy link
Contributor

zkat commented Jun 3, 2016

This was included in npm@3.9.6. Thanks a bunch! 🎉

@zkat zkat closed this Jun 3, 2016
@mmalecki mmalecki deleted the remove-unused-dependencies branch June 7, 2016 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-to-latest target-latest
Projects
None yet
Milestone
3.9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalecki @zkat