remove version parsing from #name selector, remove npm-package-arg, remove semver
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: You can no longer select a version along with an name selector (i.e. `#npm@9.0.0`). Use `#name:semver()` instead. semver and dependency type selectors collide in syntax, so we are no longer trying to parse a version with a name selector. An example can show why this is impossible to parse: `@npmcli/test-package@1.2.3-pre.prod`. There is no way to know if `.prod` is supposed to be the `.prod` dependency type selector or if it is part of the pre-release section of the version. So now you must use one of these two syntaxes depending on what the version actually is: If `.prod` is part of the version: `#@npmcli/test-package:semver(1.2.3-pre.prod)` If `.prod` is a dependency type selector: `#@npmcli/test-package:semver(1.2.3-pre).prod`
It was only being used when trying to parse versions as part of the `#name` selector.
wraithgar
force-pushed
the
gar/npa-breaking-changes
branch
from
311acdf to
058763e
Compare
wraithgar
changed the title
#foo@1 and #foo@*npm-package-arg
It was only being used when trying to parse versions as part of the `#name` selector
wraithgar
changed the title
npm-package-argnpm-package-arg, remove semver
nlf
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: You can no longer select a version along with an name
selector (i.e.
#npm@9.0.0). Use#name:semver()instead.semver and dependency type selectors collide in syntax, so we are no
longer trying to parse a version with a name selector.
An example can show why this is impossible to parse:
@npmcli/test-package@1.2.3-pre.prod.There is no way to know if
.prodis supposed to be the.proddependency type selector or if it is part of the pre-release section of
the version. So now you must use one of these two syntaxes depending on
what the version actually is:
If
.prodis part of the version:#@npmcli/test-package:semver(1.2.3-pre.prod)If
.prodis a dependency type selector:#@npmcli/test-package:semver(1.2.3-pre).prod