Update to embedded-hal 1.0 where possible #136
Conversation
| [features] | ||
| embedded-hal-02 = ["microbit-common/embedded-hal-02"] |
There was a problem hiding this comment.
I would recommend not making embedded-hal 0.2 an optional feature (yet).
There's still a lot of the driver ecosystem that has not updated to 1.0, and if your target audience is newbies you want to give them the least amount of things they must change.
There was a problem hiding this comment.
I'd like to let people avoid both the extra dependency which may be unnecessary, and the confusing error messages (e.g. in hints to add missing use statements for traits) that come from depending on two different versions of the same library.
There was a problem hiding this comment.
Fair enough. I hadn't seen those particular errors first-hand in a while, so I did up a quick test and I agree - those messages are going to be tricky for newbies to parse and understand.
Optional 0.2 hal does look like a better option than the alternative.
0.2 is still used for I2C for now.
0.2 is still used for I2C for now.