Changes for the next release, detailed list of changes:

[jamesmunns]

• Update for 2018 edition
• Harmonize versions to 0.6.0-beta.1, matching -pac crates
• Update dependencies
• Massage some differences between 832 and 840 to be more consistent
• Remove Xargo.toml from 840
• Update my email address

All PRs in this family:

• nrf52832-pac
• nrf52840-pac
• nrf52-hal

[jamesmunns]

Hey @nrf-rs/nrf52, I believe this is ready to land now. I have already cut a release and published on crates.io as 0.6.0-beta.1. Could you please test with your crates locally, and let me know how it goes?

I'd like to merge this sooner than later, and if we need to iterate on master before we cut the final 0.6.0 release, that works for me.

Please see the related issues linked above for this family of PRs.

[jamesmunns]

Fixing adafruit crate now...

[jamesmunns]

Note: published 0.6.0-beta.2 with @hannobraun's Timer additions, yanked 0.6.0-beta.1 of the HAL crates.

[hannobraun]

Looks mostly good to me. Thank you, @jamesmunns!

There are two changes that I'm unsure about. Sorry for not commenting inline. GitHub is giving me a weird error message if I try to.

In your first commit, you replace this:

extern crate nrf52_hal_common;
pub use nrf52_hal_common::*;

With this:

pub use nrf52_hal_common::{self, *};

This happens in nrf52832-hal/src/lib.rs and nrf52840-hal/src/lib.rs.

Why the added re-export of nrf52_hal_common? Seems redundant, since we already re-export all its contents.

[jamesmunns]

Whoops, totally forgot these changes @hannobraun. You're right, that was an oversight. I will fix that shortly.

[jamesmunns]

This is now fixed. Once the -pac crates land (and versions are updated), this should be ready to merge.

[jamesmunns]

@hannobraun I appreciate the last minute review, feel free to yell stop whenever :)

[jamesmunns]

@hannobraun any last thoughts?

[hannobraun]

@jamesmunns Sorry, I stopped seeing the notifications for some reason, and when I noticed the backlog, you were done and I was ready for bed. I didn't have time for a full review, but I didn't see anything objectionable.

Thank you, and good job!